Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_JAVA_OPTIONS not removed when testing JREs #1171

Closed
brawaru opened this issue May 4, 2024 · 0 comments · Fixed by #1304
Closed

_JAVA_OPTIONS not removed when testing JREs #1171

brawaru opened this issue May 4, 2024 · 0 comments · Fixed by #1304
Labels
bug Something isn't working

Comments

@brawaru
Copy link
Contributor

brawaru commented May 4, 2024

Describe the bug

In 0.7.0 Modrinth App started removing _JAVA_OPTIONS when launching the game. However, this variable is never removed when testing JREs in settings.

A cascade of “Could not create the Java Virtual Machine.” error messages.

Steps to reproduce

  1. Have _JAVA_OPTIONS environment variable defined to something like -Xmx0M, which apparently what it is set to for many users that have this variable set.
  2. Start Modrinth App.
  3. Go to ⚙️ Settings, scroll down to Java settings, and press ▶️ Test next to any Java location field.
  4. Observe the ‘Could not create the Java Virtual Machine.’ error.

Expected behavior

The evil _JAVA_OPTIONS environment variable is removed even when testing JREs.

System information

Universal, Modrinth App 0.7.1.

Additional context

ICOM-3367 (likely related).
@brawaru brawaru added the bug Something isn't working label May 4, 2024
Geometrically pushed a commit that referenced this issue Jul 4, 2024
@brawaru
Consistent extension usage in imports (#1171)
d9f8746
Norbiros added a commit to Norbiros/code that referenced this issue Jul 18, 2024
@Norbiros
fix(theseus): Remove _JAVA_OPTIONS when testing JRE (modrinth#1171)
70ed541
@Norbiros Norbiros mentioned this issue Jul 18, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2024
@Norbiros
fix(theseus): Fixed multiple bugs (#1304)
797e1f1 
* fix(theseus): Resolve log tab freezing entire app (#1127, #1237)
Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.

* fix(theseus): Double opening of Socials Share link (#1136, #1074)

* fix(theseus): Proper symlinks resolution (#1236)
Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory.

* fix(theseus): Correctly recognize NeoForge mods (#1215)

* fix(theseus): Corrected `Environments` and `Loaders` filters (#899)

* fix(theseus): Remove `_JAVA_OPTIONS` when testing JRE (#1171)

* fix(theseus): Fixed opening files using `show_in_folder`
Previously, opening a mod would display the contents of the JAR file instead of its location.

* fix(theseus): Hide `.DS_Store` files (#1274, #1002, #1174)

* fix(theseus): Corrected tooltip color

* fix(theseus): Fixed white mode issues (#1144, #1010)

* fix: Corrected `Slider` min and max value handling (#1008)

* fix: Fixed rebase problems

* fix: Fixed `:deep` usage warning

* chore: Updated eslint plugins to fix conflicts with Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(theseus): Fixed multiple bugs Norbiros/code
1 participant
@brawaru