Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop user from interacting with mods when minecraft is running #2445

Open
2 of 5 tasks
denisJaved opened this issue Sep 23, 2024 · 5 comments
Open
2 of 5 tasks

Stop user from interacting with mods when minecraft is running #2445

denisJaved opened this issue Sep 23, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@denisJaved
Copy link

denisJaved commented Sep 23, 2024

Please confirm the following.

  • I checked the existing issues for duplicate feature requests
  • I have checked that this feature request is not on our roadmap

What parts of Modrinth is your feature request related too?

App

Is your suggested feature related to a problem? Please describe.

Obviously it is impossible to remove/disable mod when instance(minecraft) is running.
But theese buttons always will try to remove/disable mod when pressed.

Describe the solution you'd like

Disable buttons for disabling/enabling/updating/removing mod when minecraft is running.

Like this:
image
this done by adding disabled attribute to switch's input tag and buttons.

Describe alternatives you've considered

Before disabling/enabling/updating/removing check is minecraft running right now and if it is show user confirmation prompt.
image

Tasks

  • Implementation in fork repo (doing right now)
  • Discord thread
  • Pull request
@denisJaved denisJaved added the enhancement New feature or request label Sep 23, 2024
@denisJaved denisJaved changed the title Stop user from interacting with mod when minecraft is running Stop user from interacting with mods when minecraft is running Sep 23, 2024
@Felix14-v2
Copy link

Obviously it is impossible to remove/disable mod when instance(minecraft) is running.

This is a Windows limitation, on other systems you can interact with files, even if they are being used by a program.

@denisJaved
Copy link
Author

Limitation caused by Minecraft. Modloaders gather mods only on startup. Which means even if you would change mod file, nothing will happen until you restart game

@Felix14-v2
Copy link

Limitation caused by Minecraft

It doesn't. The issue is an inability to remove a mod file after the game launch, not the inability to "unmodify" the game on the fly.

@denisJaved
Copy link
Author

Limitation caused by Minecraft

It doesn't. The issue is an inability to remove a mod file after the game launch, not the inability to "unmodify" the game on the fly.

I know, but still you can't remove mod from game without restarting game.
Anyways both of our points are right.

@Felix14-v2
Copy link

Anyways, that's an unrelated issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants