Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for shaders shows "Environments" instead of "Loaders" in filters list #899

Closed
AdamRaichu opened this issue Nov 22, 2023 · 1 comment · Fixed by #1304
Closed
Labels
bug Something isn't working

Comments

@AdamRaichu
Copy link
Contributor

Describe the bug

The search GUI in the app for adding a shader to a modpack (either through the search button on the sidebar or the Add Content button on a modpack's page) has the Environments filters menu instead of the Loaders menu.

Steps to reproduce

  1. Open the app.
  2. Select the search icon :mag: on the left sidebar.
  3. Select the Shaders category.
  4. Scroll down in the filters sidebar until Environments is visible.

You can also observe this by, instead of opening the search menu via the sidebar, clicking on a modpack, and clicking the :mag: Add content button in step 2.

Expected behavior

The Environments category is invalid for shaders. It should instead match the web GUI which has the Loaders filters.

System information

Windows 11 22H2 (tiny11)

Verified this right after updating.

Additional context

When selecting the Client environment filter, all shaders are shown. When selecting the Server environment filter, no shaders are shown. (This at least makes sense.)

In-app shaders search (via add content button).
image

Search in web client.
image

@AdamRaichu AdamRaichu added the bug Something isn't working label Nov 22, 2023
@AdamRaichu
Copy link
Contributor Author

Can anyone see if this still exists? I don't have the launcher installed anymore, so can't check myself.

Norbiros added a commit to Norbiros/code that referenced this issue Jul 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 20, 2024
* fix(theseus): Resolve log tab freezing entire app (#1127, #1237)
Switched to `vue-typed-virtual-list` due to freezing issues in WebKit caused by `vue-virtual-scroller`, which were difficult to resolve with the previous library.

* fix(theseus): Double opening of Socials Share link (#1136, #1074)

* fix(theseus): Proper symlinks resolution (#1236)
Ensures correct symlink resolution for specific mods, the mods directory, and the entire profile directory.

* fix(theseus): Correctly recognize NeoForge mods (#1215)

* fix(theseus): Corrected `Environments` and `Loaders` filters (#899)

* fix(theseus): Remove `_JAVA_OPTIONS` when testing JRE (#1171)

* fix(theseus): Fixed opening files using `show_in_folder`
Previously, opening a mod would display the contents of the JAR file instead of its location.

* fix(theseus): Hide `.DS_Store` files (#1274, #1002, #1174)

* fix(theseus): Corrected tooltip color

* fix(theseus): Fixed white mode issues (#1144, #1010)

* fix: Corrected `Slider` min and max value handling (#1008)

* fix: Fixed rebase problems

* fix: Fixed `:deep` usage warning

* chore: Updated eslint plugins to fix conflicts with Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant