[joss-reviews#2974] Code duplication

[chkoar]

Related: openjournals/joss-reviews#2974

If I am not mistaken, the following code blocks are exactly the same. Consider a refactoring.

numerical/moead.py (48–91)
combinatorial/moead.py (52–95)

[geoffreyp]

Thank you!
Commit 2b55994

[chkoar]

moead_framework/core/sps_strategy/sps_dra.py [54:68]:

    def get_xtrem_index(self):
        """
        get boundaries sub-problems

        :return: {list<integer>} indexes of sub-problems
        """
        xtrem_index = []
        for i in range(self.algorithm.number_of_weight):
            weight = self.algorithm.weights[i]
            for j in range(self.algorithm.number_of_objective):
                if weight[j] == 1:
                    xtrem_index.append(i)
                    break

        return xtrem_index

moead_framework/core/sps_strategy/sps_random_and_boundaries.py [32:46]:

    def get_xtrem_index(self):
        """
        get boundaries sub-problems

        :return: {list<integer>} indexes of sub-problems
        """
        xtrem_index = []
        for i in range(self.algorithm.number_of_weight):
            weight = self.algorithm.weights[i]
            for j in range(self.algorithm.number_of_objective):
                if weight[j] == 1:
                    xtrem_index.append(i)
                    break

        return xtrem_index

[chkoar]

moead_framework/algorithm/abstract_moead.py [106:112]:

  self.update_current_sub_problem(sub_problem=i)
  self.mating_pool = self.mating_pool_selection(sub_problem=i)[:]
  y = self.generate_offspring(population=self.mating_pool)
  y = self.repair(solution=y)
  self.update_z(solution=y)
  self.update_solutions(solution=y, aggregation_function=self.aggregation_function, sub_problem=i)
  self.current_eval += 1

moead_framework/algorithm/combinatorial/moead_dra.py [72:78]:

  self.update_current_sub_problem(sub_problem=i)
  self.mating_pool = self.mating_pool_selection(sub_problem=i)[:]
  y = self.generate_offspring(population=self.mating_pool)
  y = self.repair(solution=y)
  self.update_z(solution=y)
  self.update_solutions(solution=y, aggregation_function=self.aggregation_function, sub_problem=i)
  self.current_eval += 1

[geoffreyp]

Pull request #67