chore: add auth-service snippets #17
Conversation
kleyow
force-pushed
the
feature/auth-snippet-additions
branch
from
00ef8fd to
5e98ebd
Compare
|
re: KeyHandleId. String is fine for now. Couldn't find the format of a Key Handle but it'd be nice if we had pattern matching and a explicit |
| @@ -0,0 +1,28 @@ | |||
| title: UpdateCredentialRequest | |||
There was a problem hiding this comment.
Really confused about this definition. It doesn't be seem to be a request but more akin to a property used in ConsentIDPutRequest https://github.com/mojaloop/api-snippets/pull/17/files#diff-2b332d878ba42f73f319a12fb3fccfb4R22 .
Maybe something like CredentialProof? @Auth-Team
There was a problem hiding this comment.
I think this was my fault - and there's a good chance I did something wrong here.
One of the challenges/quirks with the api design is that we have a ton of fields which could be null or undefined. My goal with request bodies (or parts of request bodies) was to have a schema which would be very explicit, and thus make writing the types and code much easier.
Renaming it from ...Request would make this less confusing - CredentialProof seems suitable, or perhaps UpdatedCredential
There was a problem hiding this comment.
UpdatedCredential sounds good. done.
Decided to do auth-service as well since it gives me a better view of the api definition as a whole.
No
/docsfile generated yet. Need to merge thirdparty-api-adapter changes first so I can make changes in order.