Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update post fxTransfers validation #184

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions docs/fspiop-rest-v2.0-ISO20022-openapi3-snippets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2967,8 +2967,8 @@ components:
VrfctnOfTerms:
Cntt: CONTENT
CnttTp: PROPRIETARY
CreditTransferTransaction68_Put_FX_Quotes_ID:
title: CreditTransferTransaction68_Put_FX_Quotes_ID
CreditTransferTransaction68_FX_Quotes:
title: CreditTransferTransaction68_FX_Quotes
description: >
Provides further details specific to the individual transaction(s)
included in the message.
Expand Down Expand Up @@ -3042,8 +3042,7 @@ components:
Account to which a credit entry is made.
InstrForCdtrAgt:
allOf:
- $ref: >-
#/components/schemas/InstructionForCreditorAgent3_Put_FX_Quotes_ID
- $ref: "#/components/schemas/InstructionForCreditorAgent3_FX_Quotes"
- description: >
InstructionForCreditorAgent

Expand Down Expand Up @@ -3715,7 +3714,7 @@ components:
included in the message.
CdtTrfTxInf:
allOf:
- $ref: "#/components/schemas/CreditTransferTransaction68"
- $ref: "#/components/schemas/CreditTransferTransaction68_FX_Quotes"
- description: |
Credit Transfer Transaction Information
required:
Expand Down Expand Up @@ -3815,10 +3814,9 @@ components:
included in the message.
CdtTrfTxInf:
allOf:
- $ref: >-
#/components/schemas/CreditTransferTransaction68_Put_FX_Quotes_ID
- $ref: "#/components/schemas/CreditTransferTransaction68_FX_Quotes"
- description: >
CreditTransferTransaction68_Put_FX_Quotes_ID
CreditTransferTransaction68_FX_Quotes

Set of elements providing information specific to the individual
credit transfer(s).
Expand Down Expand Up @@ -4759,7 +4757,7 @@ components:
example:
Cd: PHOA
InstrInf: Please advise/contact next agent by phone.
InstructionForCreditorAgent3_Put_FX_Quotes_ID:
InstructionForCreditorAgent3_FX_Quotes:
title: InstructionForCreditorAgent3_Put_FX_Quotes_ID
description: >
Further information related to the processing of the payment
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
title: CreditTransferTransaction68_Put_FX_Quotes_ID
title: CreditTransferTransaction68_FX_Quotes
description: >
Provides further details specific to the individual transaction(s) included in
the message.
Expand Down Expand Up @@ -76,7 +76,7 @@ properties:
Account to which a credit entry is made.
InstrForCdtrAgt:
allOf:
- $ref: ./InstructionForCreditorAgent3_Put_FX_Quotes_ID.yaml
- $ref: ./InstructionForCreditorAgent3_FX_Quotes.yaml
- description: >
InstructionForCreditorAgent

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ properties:
Set of characteristics shared by all individual transactions included in the message.
CdtTrfTxInf:
allOf:
- $ref: ./CreditTransferTransaction68.yaml
- $ref: ./CreditTransferTransaction68_FX_Quotes.yaml
- description: >
Credit Transfer Transaction Information
required:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ properties:
Set of characteristics shared by all individual transactions included in the message.
CdtTrfTxInf:
allOf:
- $ref: ./CreditTransferTransaction68_Put_FX_Quotes_ID.yaml
- $ref: ./CreditTransferTransaction68_FX_Quotes.yaml
- description: >
CreditTransferTransaction68_Put_FX_Quotes_ID
CreditTransferTransaction68_FX_Quotes

Set of elements providing information specific to the individual credit transfer(s).
required:
Expand Down
26 changes: 14 additions & 12 deletions src/fspiop/v2_0_ISO20022/json-schemas.json
Original file line number Diff line number Diff line change
Expand Up @@ -32490,8 +32490,8 @@
}
}
},
"CreditTransferTransaction68_Put_FX_Quotes_ID": {
"title": "CreditTransferTransaction68_Put_FX_Quotes_ID",
"CreditTransferTransaction68_FX_Quotes": {
"title": "CreditTransferTransaction68_FX_Quotes",
"description": "Provides further details specific to the individual transaction(s) included in the message.\n",
"type": "object",
"properties": {
Expand Down Expand Up @@ -61685,7 +61685,7 @@
"CdtTrfTxInf": {
"allOf": [
{
"title": "CreditTransferTransaction68",
"title": "CreditTransferTransaction68_FX_Quotes",
"description": "Provides further details specific to the individual transaction(s) included in the message.\n",
"type": "object",
"properties": {
Expand Down Expand Up @@ -71348,7 +71348,7 @@
"InstrForCdtrAgt": {
"allOf": [
{
"title": "InstructionForCreditorAgent3",
"title": "InstructionForCreditorAgent3_Put_FX_Quotes_ID",
"description": "Further information related to the processing of the payment instruction, provided by the initiating party, and intended for the creditor agent.\n",
"type": "object",
"properties": {
Expand All @@ -71370,12 +71370,14 @@
"InstrInf": {
"allOf": [
{
"title": "Max140Text",
"description": "Specifies a character string with a maximum length of 140 characters.\n",
"title": "AmountTypeEnum",
"description": "NOTE: This pattern is not the original ISO20022 specification.\n This represents the enum values when mapping to and from FSPIOP specification.\n",
"type": "string",
"minLength": 1,
"maxLength": 140,
"example": 12345
"enum": [
"SEND",
"RECEIVE"
],
"example": "SEND"
},
{
"description": "InstructionInformation\nFurther information complementing the coded instruction or instruction to the creditor's agent that is bilaterally agreed or specific to a user community.\n"
Expand Down Expand Up @@ -72536,7 +72538,7 @@
"CdtTrfTxInf": {
"allOf": [
{
"title": "CreditTransferTransaction68_Put_FX_Quotes_ID",
"title": "CreditTransferTransaction68_FX_Quotes",
"description": "Provides further details specific to the individual transaction(s) included in the message.\n",
"type": "object",
"properties": {
Expand Down Expand Up @@ -82426,7 +82428,7 @@
}
},
{
"description": "CreditTransferTransaction68_Put_FX_Quotes_ID\nSet of elements providing information specific to the individual credit transfer(s).\n"
"description": "CreditTransferTransaction68_FX_Quotes\nSet of elements providing information specific to the individual credit transfer(s).\n"
}
]
}
Expand Down Expand Up @@ -120576,7 +120578,7 @@
"InstrInf": "Please advise/contact next agent by phone."
}
},
"InstructionForCreditorAgent3_Put_FX_Quotes_ID": {
"InstructionForCreditorAgent3_FX_Quotes": {
"title": "InstructionForCreditorAgent3_Put_FX_Quotes_ID",
"description": "Further information related to the processing of the payment instruction, provided by the initiating party, and intended for the creditor agent.\n",
"type": "object",
Expand Down
12 changes: 6 additions & 6 deletions src/fspiop/v2_0_ISO20022/openapi.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1180,7 +1180,7 @@ export interface components {
VrfctnOfTerms?: components["schemas"]["CryptographicLockChoice"] & unknown;
};
/**
* CreditTransferTransaction68_Put_FX_Quotes_ID
* CreditTransferTransaction68_FX_Quotes
* @description Provides further details specific to the individual transaction(s) included in the message.
*
* @example {
Expand Down Expand Up @@ -1236,7 +1236,7 @@ export interface components {
* }
* }
*/
CreditTransferTransaction68_Put_FX_Quotes_ID: {
CreditTransferTransaction68_FX_Quotes: {
PmtId: components["schemas"]["PaymentIdentification13"] & unknown;
PmtTpInf?: components["schemas"]["PaymentTypeInformation28"] & unknown;
UndrlygCstmrCdtTrf?: components["schemas"]["UnderlyingCustomerCreditTransfer"] & unknown;
Expand All @@ -1247,7 +1247,7 @@ export interface components {
CdtrAgt?: components["schemas"]["BranchAndFinancialInstitutionIdentification8"] & unknown;
Cdtr: components["schemas"]["BranchAndFinancialInstitutionIdentification8"] & unknown;
CdtrAcct?: components["schemas"]["CashAccount40"] & unknown;
InstrForCdtrAgt?: components["schemas"]["InstructionForCreditorAgent3_Put_FX_Quotes_ID"] & unknown;
InstrForCdtrAgt?: components["schemas"]["InstructionForCreditorAgent3_FX_Quotes"] & unknown;
Purp?: components["schemas"]["Purpose2Choice"] & unknown;
VrfctnOfTerms?: components["schemas"]["CryptographicLockChoice"] & unknown;
};
Expand Down Expand Up @@ -1765,7 +1765,7 @@ export interface components {
*/
FxRequest_FICreditTransferProposal: {
GrpHdr: components["schemas"]["GroupHeader113"] & unknown;
CdtTrfTxInf: components["schemas"]["CreditTransferTransaction68"] & unknown;
CdtTrfTxInf: components["schemas"]["CreditTransferTransaction68_FX_Quotes"] & unknown;
};
/**
* FxResponse_FICreditTransferConfirmation
Expand Down Expand Up @@ -1878,7 +1878,7 @@ export interface components {
*/
FxResponse_FICreditTransferConfirmation: {
GrpHdr: components["schemas"]["GroupHeader113"] & unknown;
CdtTrfTxInf: components["schemas"]["CreditTransferTransaction68_Put_FX_Quotes_ID"] & unknown;
CdtTrfTxInf: components["schemas"]["CreditTransferTransaction68_FX_Quotes"] & unknown;
};
/**
* Fxecute_FinancialInstitutionCreditTransferV12
Expand Down Expand Up @@ -2494,7 +2494,7 @@ export interface components {
* "InstrInf": "Please advise/contact next agent by phone."
* }
*/
InstructionForCreditorAgent3_Put_FX_Quotes_ID: {
InstructionForCreditorAgent3_FX_Quotes: {
Cd?: components["schemas"]["ExternalCreditorAgentInstruction1Code"] & unknown;
InstrInf?: components["schemas"]["AmountTypeEnum"] & unknown;
};
Expand Down
4 changes: 2 additions & 2 deletions src/fspiop/v2_0_ISO20022/schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export namespace Schemas {
export const CountryCode = JsonSchemas.CountryCode
export const CreditTransferTransaction67 = JsonSchemas.CreditTransferTransaction67
export const CreditTransferTransaction68 = JsonSchemas.CreditTransferTransaction68
export const CreditTransferTransaction68_Put_FX_Quotes_ID = JsonSchemas.CreditTransferTransaction68_Put_FX_Quotes_ID
export const CreditTransferTransaction68_FX_Quotes = JsonSchemas.CreditTransferTransaction68_FX_Quotes
export const CryptographicLockChoice = JsonSchemas.CryptographicLockChoice
export const DateAndDateTime2Choice = JsonSchemas.DateAndDateTime2Choice
export const DateAndPlaceOfBirth1 = JsonSchemas.DateAndPlaceOfBirth1
Expand Down Expand Up @@ -97,7 +97,7 @@ export namespace Schemas {
export const IdentificationVerificationIndicator = JsonSchemas.IdentificationVerificationIndicator
export const Instruction4Code = JsonSchemas.Instruction4Code
export const InstructionForCreditorAgent3 = JsonSchemas.InstructionForCreditorAgent3
export const InstructionForCreditorAgent3_Put_FX_Quotes_ID = JsonSchemas.InstructionForCreditorAgent3_Put_FX_Quotes_ID
export const InstructionForCreditorAgent3_FX_Quotes = JsonSchemas.InstructionForCreditorAgent3_FX_Quotes
export const InstructionForNextAgent1 = JsonSchemas.InstructionForNextAgent1
export const LEIIdentifier = JsonSchemas.LEIIdentifier
export const LocalInstrument2Choice = JsonSchemas.LocalInstrument2Choice
Expand Down
4 changes: 2 additions & 2 deletions src/fspiop/v2_0_ISO20022/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export namespace Types {
export type CountryCode = components['schemas']['CountryCode']
export type CreditTransferTransaction67 = components['schemas']['CreditTransferTransaction67']
export type CreditTransferTransaction68 = components['schemas']['CreditTransferTransaction68']
export type CreditTransferTransaction68_Put_FX_Quotes_ID = components['schemas']['CreditTransferTransaction68_Put_FX_Quotes_ID']
export type CreditTransferTransaction68_FX_Quotes = components['schemas']['CreditTransferTransaction68_FX_Quotes']
export type CryptographicLockChoice = components['schemas']['CryptographicLockChoice']
export type DateAndDateTime2Choice = components['schemas']['DateAndDateTime2Choice']
export type DateAndPlaceOfBirth1 = components['schemas']['DateAndPlaceOfBirth1']
Expand Down Expand Up @@ -97,7 +97,7 @@ export namespace Types {
export type IdentificationVerificationIndicator = components['schemas']['IdentificationVerificationIndicator']
export type Instruction4Code = components['schemas']['Instruction4Code']
export type InstructionForCreditorAgent3 = components['schemas']['InstructionForCreditorAgent3']
export type InstructionForCreditorAgent3_Put_FX_Quotes_ID = components['schemas']['InstructionForCreditorAgent3_Put_FX_Quotes_ID']
export type InstructionForCreditorAgent3_FX_Quotes = components['schemas']['InstructionForCreditorAgent3_FX_Quotes']
export type InstructionForNextAgent1 = components['schemas']['InstructionForNextAgent1']
export type LEIIdentifier = components['schemas']['LEIIdentifier']
export type LocalInstrument2Choice = components['schemas']['LocalInstrument2Choice']
Expand Down