Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mojaloop/#3020): add checks for when mongodb is disabled #927

Merged
merged 13 commits into from
Nov 24, 2022

Conversation

kleyow
Copy link
Contributor

@kleyow kleyow commented Nov 18, 2022

No description provided.

@kleyow kleyow marked this pull request as ready for review November 18, 2022 22:46
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some mior suggested changes.

config/default.json Outdated Show resolved Hide resolved
src/handlers/bulk/fulfil/handler.js Outdated Show resolved Hide resolved
src/handlers/bulk/get/handler.js Outdated Show resolved Hide resolved
src/handlers/bulk/prepare/handler.js Outdated Show resolved Hide resolved
src/handlers/bulk/processing/handler.js Outdated Show resolved Hide resolved
kleyow and others added 2 commits November 24, 2022 07:16
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kleyow kleyow merged commit 7461d9b into master Nov 24, 2022
@kleyow kleyow deleted the chore/warning branch November 24, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants