fix: disconnect from Kafka on process exit #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deployments in k8s are restarted or scaled down, the pods that get terminated must make sure that all created consumers are explicitly disconnected. If consumers are not disconnected, Kafka still sees the old connections and there is and increased delay for rebalancing the corresponding consumer group.
The process exit event does not allow async processing, that's why this helper module is used.