-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot build ml-api-adapter with current version of central-services-stream #141
Conversation
CircleCI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@elnyry-sam-k I assigned you for review as this fix also includes an implementation for the pre-release branches. There is also something strange, whereby Circle CI is reported as not signed the CLA, see this: |
Hmm, that is technically true; there are commits on here shown from circleCI and apparently it hasn't signed, so looks okay. We can probably override that part (for example: 2eb3459 ). But, let me look at it closer. |
This repo also needs a codeowners file |
These commits should show up from mojaloopci and not circleci, not sure where the diff is, need to check that. |
Quality Gate passedIssues Measures |
@elnyry-sam-k, please approve if all is good |
perfect, thank you! |
Fixes #140