Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot build ml-api-adapter with current version of central-services-stream #141

Merged
merged 30 commits into from
May 16, 2024

Conversation

kalinkrustev
Copy link
Contributor

@kalinkrustev kalinkrustev commented May 14, 2024

Fixes #140

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kalinkrustev
❌ CircleCI


CircleCI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kalinkrustev kalinkrustev marked this pull request as ready for review May 14, 2024 14:27
@kalinkrustev kalinkrustev requested a review from elnyry-sam-k May 14, 2024 14:40
@kalinkrustev
Copy link
Contributor Author

kalinkrustev commented May 14, 2024

@elnyry-sam-k I assigned you for review as this fix also includes an implementation for the pre-release branches.

There is also something strange, whereby Circle CI is reported as not signed the CLA, see this:
image

@kalinkrustev kalinkrustev changed the title Patch/140 fix: cannot build ml-api-adapter with current version of central-services-stream May 14, 2024
geka-evk
geka-evk previously approved these changes May 15, 2024
@elnyry-sam-k
Copy link
Member

@elnyry-sam-k I assigned you for review as this fix also includes an implementation for the pre-release branches.

There is also something strange, whereby Circle CI is reported as not signed the CLA, see this: image

Hmm, that is technically true; there are commits on here shown from circleCI and apparently it hasn't signed, so looks okay. We can probably override that part (for example: 2eb3459 ). But, let me look at it closer.

@elnyry-sam-k
Copy link
Member

This repo also needs a codeowners file

@elnyry-sam-k
Copy link
Member

These commits should show up from mojaloopci and not circleci, not sure where the diff is, need to check that.

@kalinkrustev
Copy link
Contributor Author

These commits should show up from mojaloopci and not circleci, not sure where the diff is, need to check that.

I fixed this here 28e1392, the next commit 0edeeda is from mojaloopci.

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kalinkrustev
Copy link
Contributor Author

@elnyry-sam-k, please approve if all is good

@elnyry-sam-k
Copy link
Member

perfect, thank you!

@kalinkrustev kalinkrustev merged commit 68e9cb9 into master May 16, 2024
8 of 9 checks passed
@kalinkrustev kalinkrustev deleted the patch/140 branch May 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build ml-api-adapter with current version of central-services-stream
4 participants