Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Kafka configuration via the environment or convict #143

Merged
merged 3 commits into from
May 24, 2024

Conversation

kalinkrustev
Copy link
Contributor

@kalinkrustev kalinkrustev commented May 21, 2024

fixes #142 by allowing configuration properties to be specified in camelCase and converted to camel.case before passed to node-rdkafka

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kalinkrustev kalinkrustev changed the title feat: enable Kafka configuration via the environment feat: enable Kafka configuration via the environment or convict May 22, 2024
@kalinkrustev kalinkrustev self-assigned this May 22, 2024
@kalinkrustev kalinkrustev marked this pull request as ready for review May 24, 2024 08:07
@kalinkrustev kalinkrustev requested a review from vijayg10 May 24, 2024 08:24
@kalinkrustev kalinkrustev merged commit 11cee90 into master May 24, 2024
11 checks passed
@kalinkrustev kalinkrustev deleted the feat/event-kafka branch May 24, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka client cannot be configured via convict or environment variables
2 participants