-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mojaloop/#2734): failures in daily cron job running gp tests #146
Merged
mdebarros
merged 26 commits into
master
from
fix/#2734-failures-in-daily-cron-job-running-GP-tests
Sep 8, 2022
Merged
fix(mojaloop/#2734): failures in daily cron job running gp tests #146
mdebarros
merged 26 commits into
master
from
fix/#2734-failures-in-daily-cron-job-running-GP-tests
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed logging to correctly display request logs. this is needed to help debug issues
- updated dependencies - updated husky to latest version, and moved config from package.json to .husky folder
- replaced module-alias with native import aliass
Example request being logged with actual request {
app: 'test-api',
request: {
id: 'whining-creamy-late-salesclerk',
path: '/repository/parties',
method: 'POST'
},
body: { <-- This was previously missing
displayName: 'testfsp4WalletFname testfsp4WalletLname',
firstName: 'testfsp4WalletFname',
middleName: '',
lastName: 'testfsp4WalletLname',
dateOfBirth: '1985-05-13',
idType: 'MSISDN',
idValue: '17891239872',
extensionList: [ { key: 'accountType', value: 'Wallet' } ]
},
msg: 'Request received',
timestamp: '2022-09-06T10:50:30.615Z'
} |
elnyry-sam-k
previously approved these changes
Sep 7, 2022
elnyry-sam-k
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mojaloop/#2734): failures in daily cron job running gp tests - mojaloop/project#2734
CONFIG_OVERRIDE
env var to support using example.env for unit/integration tests, with default being.env
when runningnpm start
.chore: maintenance