Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement createSettlementModel admin API #1179

Closed
12 of 13 tasks
ggrg opened this issue Jan 22, 2020 · 0 comments
Closed
12 of 13 tasks

Implement createSettlementModel admin API #1179

ggrg opened this issue Jan 22, 2020 · 0 comments
Assignees
@lazolalucas
Labels
story

Comments

@ggrg
Copy link
Member

ggrg commented Jan 22, 2020 •
edited by lazolalucas
Loading

Goal:

As a Hub Operator
I want to have the functionality on the admin API (POST /settlementModel) to set a settlement model
so that I can use it to set the settlement model my scheme uses

Notes:

  • The only settlement models in this context are MULTILATERAL NET DEFERRED and MULTILATERAL GROSS IMMEDIATE
  • Proposed API or resource is POST /settlementModel

Tasks:

  • Add POST route with Joi validations
  • Add ENUMS to shared lib
  • Create handler script
  • Implement DAO script
  • Provide unit tests to cover newly added functionality
  • Address PR comments

Acceptance Criteria:

  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lazolalucas lazolalucas

Labels
story
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lazolalucas @ggrg