Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve createSettlement to fail attempts for continuous/gross models #1209

Closed
15 tasks done
ggrg opened this issue Feb 7, 2020 · 0 comments
Closed
15 tasks done

Improve createSettlement to fail attempts for continuous/gross models #1209

ggrg opened this issue Feb 7, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@ggrg
Copy link
Member

ggrg commented Feb 7, 2020

Goal:

As a Hub Operator
I want to make sure no settlement can be initiated for IMMEDIATE/GROSS models
so that only DEFERRED/NET models may result in a successful settlement create operation

Tasks:

  • Set up various combination for settlement models (e.g. IMMEDIATE/GROSS, DEFERRED/GROSS) [@ggrg]
  • Merge Node v2 upgrade from master into settlement-v2 for central-ledger and central-settlement. Also utilise upgraded ml-api-adapter and mojaloop/simulator for central-settlement integration tests run [@ggrg]
  • Add unique constraint on settlementModels to prevent similar models (delay-granularity-interchange-ledgerAccountType-currency) [@ggrg]
  • Improve createSettlement validation and make sure all of the above specified models fail with appropriate message [@ggrg]
  • Fix unit tests

Acceptance Criteria:

  • Inappropriate requests are rejected
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.
  • A Settlement cannot be explicitly be initiated when he settlement model chosen is a IMMEDIATE/GROSS model

Pull Requests:

Follow-up:

  • N/A

Dependencies:

Accountability:

@ggrg ggrg added the story label Feb 7, 2020
@ggrg ggrg self-assigned this Feb 13, 2020
@ggrg ggrg added this to the Sprint 9.2 milestone Feb 19, 2020
@ggrg ggrg closed this as completed Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant