Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance createSettlementModels admin api endpoint to allow only pre-defined settlement models #1210

Closed
15 tasks done
ggrg opened this issue Feb 7, 2020 · 1 comment
Closed
15 tasks done
Assignees
Labels

Comments

@ggrg
Copy link
Member

ggrg commented Feb 7, 2020

Goal:

As a Hub Operator
I want to be able to only define settlement models which could be mapped to real-world models
so that model definitions which don't make sense, fail upon creation attempt (e.g. DEFERRED/GROSS)

Notes:

  • This story is good to have, but is not a priority for the current PI

Tasks:

  • Create valid configuration matrix for settlement model properties: settlementGranularity, settlementInterchange, settlementDelay [@ggrg]
  • Validate proposed configuration [@ggrg, @MichaelJBRichards]
  • Implement validation and fail invalid combinations [@ggrg]
    • Update shared library [@ggrg]
    • Release shared library and implement in central-ledger admin api [@ggrg]
  • central-ledger node upgrade (driven by @mojaloop libs upgrades)

Acceptance Criteria:

  • Only valid settlement models can be added
  • Designs are up-to date
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

@ggrg ggrg added the story label Feb 7, 2020
@ggrg ggrg self-assigned this Feb 12, 2020
@ggrg
Copy link
Member Author

ggrg commented Feb 12, 2020

The following has been confirmed with @MichaelJBRichards:
image

@ggrg ggrg changed the title Enhance createSettlementModels admin api endpoint to allow only sensible settlement model definitions Enhance createSettlementModels admin api endpoint to allow only defined settlement model definitions Feb 13, 2020
@ggrg ggrg changed the title Enhance createSettlementModels admin api endpoint to allow only defined settlement model definitions Enhance createSettlementModels admin api endpoint to allow only pre-defined settlement model Feb 13, 2020
@ggrg ggrg changed the title Enhance createSettlementModels admin api endpoint to allow only pre-defined settlement model Enhance createSettlementModels admin api endpoint to allow only pre-defined settlement models Feb 13, 2020
@ggrg ggrg closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant