www: fix links in the about page

Somehow <Link> forces relative links and breaks external URLs (ex: https://buildbot.buildbot.net/#/about/http://buildbot.net). It might be fixed with react-router 6.7.1 [1], while I prefer to just use basic `<a>`. While I'm at it, I also updated the link to use HTTPS. [1] remix-run/react-router#9900
mokibit · Aug 26, 2024 · feb8ab6 · feb8ab6
1 parent 645d286
commit feb8ab6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/newsfragments/www-fix-about-page-links.bugfix b/newsfragments/www-fix-about-page-links.bugfix
@@ -0,0 +1 @@
+Fix links to external URLs in the about pages.
diff --git a/www/base/src/views/AboutView/AboutView.tsx b/www/base/src/views/AboutView/AboutView.tsx
@@ -88,8 +88,8 @@ export const AboutView = observer(() => {
         <Card.Body>
           <h2>
             <img src="icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
-            <Link to="http://buildbot.net">buildbot</Link>&nbsp;running for&nbsp;
-            <Link to={config.titleURL}>{config.title}</Link>
+            <a href="https://buildbot.net">buildbot</a>&nbsp;running for&nbsp;
+            <a href={config.titleURL}>{config.title}</a>
           </h2>
           <div className="col-sm-12">
             <ul>

diff --git a/www/react-base/src/views/AboutView/AboutView.tsx b/www/react-base/src/views/AboutView/AboutView.tsx
@@ -87,9 +87,9 @@ export const AboutView = observer(() => {
       <Card bg="light">
         <Card.Body>
           <h2>
-            <img src="img/icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
-            <Link to="http://buildbot.net">buildbot</Link>&nbsp;running for&nbsp;
-            <Link to={config.titleURL}>{config.title}</Link>
+            <img src="icon.svg" alt="" width="64px" className="nut-spin"/>&nbsp;About this&nbsp;
+            <a href="https://buildbot.net">buildbot</a>&nbsp;running for&nbsp;
+            <a href={config.titleURL}>{config.title}</a>
           </h2>
           <div className="col-sm-12">
             <ul>