Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic testing #328

Closed
nichannah opened this issue Jun 24, 2016 · 1 comment
Closed

Diagnostic testing #328

nichannah opened this issue Jun 24, 2016 · 1 comment

Comments

@nichannah
Copy link
Collaborator

This is a feature issue and an umbrella for several other issues.

We want:

  • Tests that all available diagnostics can be output.
  • Check diagnostic checksums against baseline
  • Check that diagnostics on different vertical grids are correct/consistent. This includes model, z, sigma and rho vertical coords.
  • Sort out cases where diagnostics are registered but no post, or registered, posted but not calculated. See Diagnostics which call register() but not post() #164.
@nichannah
Copy link
Collaborator Author

Moving this issue to MOM6-examples.

nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
By default use mpirun for runs when doing diagnostics tests. mom-ocea…
4bb826c 
…n#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Be able to build models before testing begins. mom-ocean#328
f654337
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Keep build output on failed build during testing. mom-ocean#328
f96bd92
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Missing define from build script used for testing. mom-ocean#328
0852ad2
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Default to GNU DEBUG builds for diagnostics testing. mom-ocean#328
bc917d7
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@angus-g
Make experiment.py work with Python 3. mom-ocean#328
8f0a259
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@angus-g
Test diagnostic data, rather than entire file. mom-ocean#328
87ccc87 
The test suite test_diagnostic_output.py required netCDF3 output because
it would hash entire diagnostic files, an operation which isn't
reproducible with netCDF4 due to timestamps. To allow netCDF4 output, we
hash just the raw diagnostic data, but none of the surrounding file.
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Keep build output on failed build during testing. mom-ocean#328
b5f1655
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Missing define from build script used for testing. mom-ocean#328
7361b91
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Update diagnostic testing to handle multiple platforms. mom-ocean#328
c1bf67d
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Correct specification of z grid used for vertical remapping. mom-ocea…
665a43f 
…n#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Update tests for diags vertically remapped to z star coordinates. mom…
65ac3b1 
…-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Update MOM6 submodule with vertical remapping changes. mom-ocean#328
68a3657
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Clean up diagnostic tests so they require fewer models runs to finish. …
62e9e88 
…mom-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Update MOM6 version. mom-ocean#328
90a8357
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Diag testing: ensure that experiment has run before processing availa…
a035f79 
…ble diags. mom-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Add link to diagnostic testing from the README. mom-ocean#328
1032171
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Update MOM6 with new vertical remapping changes. mom-ocean#328
6110b55
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Extend testing to handle dumping rho and sigma remapped diagnostics a…
800027b 
…s well as z. mom-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Increase max number of diag files. mom-ocean#328
4ac2a56
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Don't delete old diags when testing, these may be needed for manual i…
64e809c 
…nspection. mom-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
Merge and fix conflict. mom-ocean#328
c7cecd9
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
The dump diags tool should delete any diags that will be recreated. m…
94910d2 
…om-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Update test scripts to support Python3, update MOM. mom-ocean#328
f4edf7b
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Use new format to specify Z coordinate locations for diagnostic regri…
f260f57 
…dding. mom-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Python3 fixes. mom-ocean#328
94d8205
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Update MOM6 with @aja additions. mom-ocean#328
19aa406
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Correct output formatting on diagnostic test failure with Python3. mo…
909593a 
…m-ocean#328
nikizadehgfdl pushed a commit to nikizadehgfdl/MOM6 that referenced this issue Oct 9, 2017
@nichannah
Handle FMS limitations (see NOAA-GFDL/FMS#27) when
7237fdb 
dumping large numbers of diagnostics. mom-ocean#328
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Feb 28, 2023
@Hallberg-NOAA
Only root_PE makes write_energy netcdf file calls
9c25e92 
  Revised write_energy so that only the root_PE attempts to open, reopen or
write to a netcdf file.  Although FMS can handle cases where multiple PEs make
the same calls with internal logic, this change avoids requiring such internal
(hidden) logical tests, and instead is more explicit on what is actually
intended.  This change is complementary to MOM6 dev/gfdl PR mom-ocean#328, which adds
internal logic to handle the case where all PEs are making a call to reopen a
single netcdf file.  All answers and output are bitwise identical.
marshallward pushed a commit to marshallward/MOM6 that referenced this issue Mar 3, 2023
@Hallberg-NOAA @marshallward
Only root_PE makes write_energy netcdf file calls
ceb4c92 
  Revised write_energy so that only the root_PE attempts to open, reopen or
write to a netcdf file.  Although FMS can handle cases where multiple PEs make
the same calls with internal logic, this change avoids requiring such internal
(hidden) logical tests, and instead is more explicit on what is actually
intended.  This change is complementary to MOM6 dev/gfdl PR mom-ocean#328, which adds
internal logic to handle the case where all PEs are making a call to reopen a
single netcdf file.  All answers and output are bitwise identical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nichannah