Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_param_char_array() only reads first entry in list of strings #72

Closed
adcroft opened this issue Oct 14, 2014 · 0 comments
Closed

read_param_char_array() only reads first entry in list of strings #72

adcroft opened this issue Oct 14, 2014 · 0 comments
Assignees
@adcroft
Labels
bug

Comments

@adcroft
Copy link
Collaborator

adcroft commented Oct 14, 2014

I suspect I broke read_param_char_array() two years ago! It seems we haven't exercised the ability to read a list of strings since.

@jkansong reported issues reading multiple tidal input files. A list of files in is MOM_input but only the first in the list is seen by the MOM_tidal_forcing.F90 and written out by log_param().

I've think I've traced it back to read_param_char_array() which appears to expect multiple strings from get_variable_line() but get_variable_line() is only returning one string.
@adcroft adcroft added the bug label Oct 14, 2014
@adcroft adcroft self-assigned this Oct 14, 2014
adcroft added a commit that referenced this issue Oct 14, 2014
@adcroft
Fix reading of list of strings
6741ea1 
- new function for stripping quotes is invoked from read_param_char()
  and read_param_char_array().
- get_variable_line() no longer strips quotes.
- read_param_char_array() splits string on commas.
- Increased INPUT_STR_LENGTH to 200.
- Addresses issue #72.
adcroft added a commit that referenced this issue Oct 14, 2014
@adcroft
Use get_param() for TIDAL_INPUT_FILES string array
a24dcaa 
- TIDAL_INPUT_FILES was not being logged properly when
  log_param() was invoked for each element of the string array.
- Addresses issue #72.
@adcroft adcroft closed this as completed in d5af1a2 Nov 5, 2014
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this issue Jul 6, 2018
@alperaltuntas
Merge pull request mom-ocean#72 from gustavo-marques/update_KPP
bd90705 
 Sets lnoDGat1=.true. when gradient should not be matched
adcroft pushed a commit that referenced this issue Aug 28, 2019
@kshedstrom
Merge pull request #72 from ESMG/OBC_segment_data_thickness_adjust
e109eb7 
*Obc segment data thickness adjust
@jiandewang jiandewang mentioned this issue Sep 5, 2019
Merged
SMoorthi-emc pushed a commit to SMoorthi-emc/MOM6 that referenced this issue Sep 30, 2021
@jiandewang
Merge pull request mom-ocean#72 from pjpegion/ocn_stoch_july2021
36f17eb 
Ocean stochastic physics
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Mar 10, 2022
@Hallberg-NOAA
+(*)MOM_hor_visc bug fix and loop size cleanup
820f84a 
  Fixed the bug noted in issue mom-ocean#72 and excessive loop sizes noted in the
unresolved comments in a recent commit, and cleaned up other aspects of
MOM_hor_visc, mostly related to the code that is exercised when USE_GME=True.

 - Fixed the bug with the wrong arrays being used when ADD_LES_VISCOSITY=True
   that was noted in MOM6 issue mom-ocean#72.

 - Corrected some of the overly large loop extents that were noted in unresolved
   comments about MOM6 PR mom-ocean#65.

 - Only log USE_KH_BG_2D if a Laplacian viscosity is used.

 - Use extra calculations in the halos and marching in to avoid unnecessary halo
   updates in smooth_GME if there multiple smoothing passes.

 - Corrected the capitalization of some horizontal indices to follow the MOM6
   convention for indicating the horizontal staggering position.

 - Collected the post_data calls for diagnostics with use_GME with the other
   post data calls to collocate some of the potential inter-PE synchronization
   points.

 - Fixed the indentation of some expressions that were using less than 4 points
   for some continuation lines.

 - Eliminated several unused variables, and fused some loops to allow 2-d
   variables to be replaced with scalars.

  With this PR, answers can change when ADD_LES_VISCOSITY=True and there is a
Smagorinsky or Leith Laplacian viscosity and there is a nonzero background.
One run-time parameter is no longer logged if LAPLACIAN=false, so there are
changes to the MOM_parameter_doc files.  All answers in the MOM6-examples test
suite are bitwise identical.
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Mar 21, 2022
@Hallberg-NOAA @marshallward
+(*)MOM_hor_visc bug fix and loop size cleanup
ab4d226 
  Fixed the bug noted in issue mom-ocean#72 and excessive loop sizes noted in the
unresolved comments in a recent commit, and cleaned up other aspects of
MOM_hor_visc, mostly related to the code that is exercised when USE_GME=True.

 - Fixed the bug with the wrong arrays being used when ADD_LES_VISCOSITY=True
   that was noted in MOM6 issue mom-ocean#72.

 - Corrected some of the overly large loop extents that were noted in unresolved
   comments about MOM6 PR mom-ocean#65.

 - Only log USE_KH_BG_2D if a Laplacian viscosity is used.

 - Use extra calculations in the halos and marching in to avoid unnecessary halo
   updates in smooth_GME if there multiple smoothing passes.

 - Corrected the capitalization of some horizontal indices to follow the MOM6
   convention for indicating the horizontal staggering position.

 - Collected the post_data calls for diagnostics with use_GME with the other
   post data calls to collocate some of the potential inter-PE synchronization
   points.

 - Fixed the indentation of some expressions that were using less than 4 points
   for some continuation lines.

 - Eliminated several unused variables, and fused some loops to allow 2-d
   variables to be replaced with scalars.

  With this PR, answers can change when ADD_LES_VISCOSITY=True and there is a
Smagorinsky or Leith Laplacian viscosity and there is a nonzero background.
One run-time parameter is no longer logged if LAPLACIAN=false, so there are
changes to the MOM_parameter_doc files.  All answers in the MOM6-examples test
suite are bitwise identical.
marshallward added a commit to marshallward/MOM6 that referenced this issue May 3, 2022
@marshallward
Candidate branch main->dev/gfdl
41a278b 
Note that most of these commits are from previously squashed pull
requests, and this PR is restoring them.

- 6360dbb Merge branch 'main' into main_to_dev
- bac8031 Merge pull request mom-ocean#1566 from jiandewang/EMC-FMS-mixed-mode-20220411
- e532d86 Merge pull request mom-ocean#88 from marshallward/missing_attrib_with_class_bugfix
- d380f1d An alternate fix to class(*) issues with FMS 2022-01
- 8ecf333 Merge pull request mom-ocean#87 from jiandewang/feature/update-to-main-20220317
- ba37f94 Merge remote-tracking branch 'FSU/main' into feature/update-to-main-20220317 this is corresponding to MOM6 main 20220317 commit (hash # 399a7db)
- 44313d9 Merge pull request mom-ocean#85 from jiandewang/feature/update-to-main-20220217
- 966707f Merge remote-tracking branch 'GFDL/main' into feature/update-to-main-20220217 this is corresponding to MOM6 main branch 20220217 commit (hash # 6f6d4d6), which originally based on GFDL-candidate-20220129
- 32c0e1e Merge pull request mom-ocean#81 from jiandewang/feature/update-to-main-20211220
- 9642b1d delete external/OCEAN_stochastic_phyiscs directory as Phil re-coded in external/stochastic_physics directory
- e7c9ada solve minor conflict in mom_cap.F90 mom_ocean_model_nuopc.F90 and MOM_energetic_PBL.F90, add two new files: src/parameterizations/stochastic/MOM_stochastics.F90 and config_src/external/stochastic_physics/stochastic_physics.F90
- 90d5961 Merge pull request mom-ocean#78 from jiandewang/feature/update-to-GFDL-20211019
- fd02017 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20211019
- 36f17eb Merge pull request mom-ocean#72 from pjpegion/ocn_stoch_july2021
- a9a957e return a more accurate error message in MOM_stochasics
- 56bb41e Merge branch 'ocn_stoch_july2021' of https://github.com/pjpegion/MOM6 into ocn_stoch_july2021
- ca2ae1c update to dev/emc
- 14ca4a1 Merge pull request mom-ocean#76 from jiandewang/feature/update-to-GFDL-20210914
- 29016c2 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20210914 merge GFDL main 20210914 commit (hash # c09e199)
- a8577df Merge branch 'NOAA-EMC:dev/emc' into ocn_stoch_july2021
- f8a8e4c update to gfdl 20210806 (mom-ocean#74)
- 16e6af0 update to dev/emc
- 237a510 add comments
- 1b4273d revert logic wrt increments
- 5b2040e add logic to remove incrments from restart if outside IAU window
- c5f2b72 add write_stoch_restart_ocn to MOM_stochastics
- bdf2dc7 doxygen cleanup
- 8bc4acc move stochastics to external directory
- a3fa3a1 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch_july2021
- e4bc007 stochastic physics re-write
- 202cbd4 update to dev/emc
- 61717ee Merge remote-tracking branch 'origin/dev/emc' into ocn_stoch
- 565e0bb remove debug statements
- a4c0411 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 689a73f remove PE_here from mom_ocean_model_nuopc.F90
- 8afe969 clean up of mom_ocean_model_nuopc.F90
- 25ed4fc revert MOM_domains.F90
- b8d9888 place stochastic array in fluxes container and make SPPT specific arrays allocatable
- d984a7e remove stochastics container
- eb88219 clean up of code for MOM6 coding standards
- 6e3ea1b correct coupled_driver/ocean_model_MOM.F90 and other cleanup
- 0b99c1f make stochastics optional
- 85023f8 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 80f9f44 clean up MOM_domains
- 5443f8e remove blank link in MOM_diagnostics
- 1727d9a re-write of stochastic code to remove CPP directives
- 600ebf9 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 6bb9d0b fix non stochastic ePBL calculation
- 1d7ffa3 clean up code
- 040e1f1 Merge pull request #13 from NOAA-EMC/dev/emc
- 2cba995 Merge branch 'dev/emc' into ocn_stoch
- 1dc0f4f Merge remote-tracking branch 'upstream/dev/emc' into dev/emc
- 4bd9b9e clean up debug statements
- 25ed5ef additions for stochy restarts
- a2a374b add stochy_restart writing to mom_cap
- 0c15f4c Update MOM_diabatic_driver.F90
- 167a62e Merge pull request #12 from pjpegion/dev/emc
- bd477a9 Update MOM_diabatic_driver.F90
- 7212400 Update MOM_diabatic_driver.F90
- 7de295c cleanup of code and enhancement of ePBL perts
- cd06356 Merge pull request #11 from NOAA-EMC/dev/emc
- 9896d61 Merge pull request #9 from pjpegion/dev/emc_merge
- 0a62737 Merge branch 'ocn_stoch' into dev/emc_merge
- 3cad1ba Merge pull request #8 from NOAA-EMC/dev/emc
- c2aa2a8 updates from dev/emc
- 182ef34 additions for stochastic physics and ePBL perts
- 671c714 Merge pull request #1 from NOAA-EMC/dev/emc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcroft adcroft

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adcroft