Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ale sponges ongrid #1000

Merged
merged 9 commits into from
Sep 19, 2019
Merged

Conversation

MJHarrison-GFDL
Copy link
Contributor

I am keeping the new test hidden because it will break Travis. Need prep.bash script containing python to run first.

.testing/_tc4/build_grid.py Outdated Show resolved Hide resolved
.testing/_tc4/build_grid.py Outdated Show resolved Hide resolved
.testing/_tc4/build_grid.py Outdated Show resolved Hide resolved
.testing/_tc4/build_grid.py Outdated Show resolved Hide resolved
.testing/_tc4/diag_table Outdated Show resolved Hide resolved
.testing/_tc4/prep.bash Outdated Show resolved Hide resolved
src/framework/MOM_horizontal_regridding.F90 Outdated Show resolved Hide resolved
@adcroft
Copy link
Collaborator

adcroft commented Sep 17, 2019

BTW, congratulations on getting issue # 1000 .

@adcroft
Copy link
Collaborator

adcroft commented Sep 17, 2019

GH is still showing a conflict at L737 of MOM_horizontal_regridding.F90. Until the conflict is resolved GH wont launch the CI.

@codecov-io
Copy link

codecov-io commented Sep 17, 2019

Codecov Report

Merging #1000 into dev/gfdl will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1000      +/-   ##
============================================
- Coverage     43.12%   43.11%   -0.01%     
============================================
  Files           213      213              
  Lines         62350    62351       +1     
============================================
- Hits          26886    26885       -1     
- Misses        35464    35466       +2
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_ALE_sponge.F90 0% <0%> (ø) ⬆️
src/framework/MOM_horizontal_regridding.F90 0% <0%> (ø) ⬆️
src/framework/MOM_file_parser.F90 64.2% <0%> (-2.88%) ⬇️
src/framework/MOM_coms.F90 53.01% <0%> (-0.96%) ⬇️
...arameterizations/vertical/MOM_bulk_mixed_layer.F90 57.15% <0%> (-0.07%) ⬇️
src/tracer/MOM_tracer_hor_diff.F90 87.21% <0%> (+0.13%) ⬆️
src/core/MOM_barotropic.F90 71.92% <0%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c00c8...71da10f. Read the comment docs.

Copy link
Collaborator

@adcroft adcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adcroft adcroft merged commit af4a364 into mom-ocean:dev/gfdl Sep 19, 2019
@MJHarrison-GFDL MJHarrison-GFDL deleted the ALE_sponges_ongrid branch December 3, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants