Ice shelf and barotropic rescale variable init #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some index bounds in the ice shelf code were not initialized to the grid values. This patch sets those values. The vel_rescale parameter used in barotropic_init was also absent from one block of code, and has been added. (This is probably a temporary variable that will be phased out as dimensional scaling progresses.) Presumably none of this code was being run, because it would have normally caused severe problems.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1021 +/- ##
============================================
- Coverage 43.61% 43.61% -0.01%
============================================
Files 212 212
Lines 62173 62176 +3
============================================
Hits 27116 27116
- Misses 35057 35060 +3
Continue to review full report at Codecov.
|
Hallberg-NOAA
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some index bounds in the ice shelf code were not initialized to the grid
values. This patch sets those values.
The vel_rescale parameter used in barotropic_init was also absent from
one block of code, and has been added. (This is probably a temporary
variable that will be phased out as dimensional scaling progresses.)
Presumably none of this code was being run, because it would have
normally caused severe problems.