Adds TIME macro to .testing/Makefile #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simply provides a means to avoid out-of-order output when running `make test -j` in parallel. By default we can get output like this: ``` PASS: Diagnostics tc4.dim.q.diag agree. PASS: Diagnostics tc4.openmp.diag agree. PASS: Diagnostics tc4.dim.r.diag agree. real 0m16.012s user 0m0.129s sys 0m0.268s real 0m15.761s user 0m0.116s sys 0m0.318s real 0m15.940s user 0m0.112s sys 0m0.302s real 0m15.705s user 0m0.177s sys 0m0.251s DONE: tc2.a.dim.l; no runtime errors. DONE: tc2.a.nan; no runtime errors. DONE: tc2.dim.z; no runtime errors. ``` but by adding `TIME =` to config.mk or invoking in bash with `TIME="" make test -j` the times are omitted and output cleaner.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1230 +/- ##
============================================
+ Coverage 46.08% 46.13% +0.04%
============================================
Files 214 224 +10
Lines 69399 71022 +1623
============================================
+ Hits 31984 32763 +779
- Misses 37415 38259 +844
Continue to review full report at Codecov.
|
|
I almost wonder if But this is an incrementally positive step and we can disable it later if there is any feedback to do so. (NOTE: This does not touch code so does not require a regression test.) |
marshallward
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply provides a means to avoid out-of-order output when running
make test -jin parallel. By default we can get output like this:but by adding
TIME =to config.mk or invoking in bash withTIME="" make test -jthe times are omitted and output cleaner.