Correct units of integrated salt flux diagnostics #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the documented units of diagnostics of globally integrated salt flux diagnostics. Also removed two declarations of cmor_units that are redundant with the ordinary units for these diagnostics, and corrected the logical test for an error message related to lateral boundary diffusion. All answers are bitwise identical, but there are changes in the units in available_diags files and in the metadata of some output files.
marshallward
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the documented units of diagnostics of globally integrated salt flux
diagnostics. Also removed two declarations of cmor_units that are redundant
with the ordinary units for these diagnostics, and corrected the logical test
for an error message related to lateral boundary diffusion. All answers are
bitwise identical, but there are changes in the units in available_diags files
and in the metadata of some output files.