Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unneeded variables in diabatic_driver #1267

Merged
merged 2 commits into from
Dec 11, 2020

Conversation

Hallberg-NOAA
Copy link
Collaborator

Eliminated unnecessary variables and some repetitive calculations from
diabatic_driver.F90. Also replaced G%ke with GV%ke in this file and added
units to some defining comments. All answers and output are bitwise identical.

Hallberg-NOAA and others added 2 commits December 2, 2020 06:26
  Eliminated unnecessary variables and some repetitive calculations from
diabatic_driver.F90.  Also replaced G%ke with GV%ke in this file and added
units to some defining comments.  All answers and output are bitwise identical.
@codecov-io
Copy link

Codecov Report

Merging #1267 (b9ae6f9) into dev/gfdl (e7e6c4a) will decrease coverage by 0.02%.
The diff coverage is 79.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1267      +/-   ##
============================================
- Coverage     45.78%   45.76%   -0.03%     
============================================
  Files           225      225              
  Lines         71458    71435      -23     
============================================
- Hits          32714    32689      -25     
- Misses        38744    38746       +2     
Impacted Files Coverage Δ
...parameterizations/vertical/MOM_diabatic_driver.F90 63.96% <79.54%> (-0.48%) ⬇️
...rameterizations/vertical/MOM_diapyc_energy_req.F90 0.00% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7e6c4a...b9ae6f9. Read the comment docs.

@marshallward
Copy link
Collaborator

marshallward commented Dec 11, 2020

@marshallward marshallward merged commit 446becc into mom-ocean:dev/gfdl Dec 11, 2020
@Hallberg-NOAA Hallberg-NOAA deleted the simplify_diabatic branch July 30, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants