Disconnect MOM_random from FMS/random #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The random number generator is not really infrastructure code but was shared code. Since we are trying to make MOM6 agnostic to the infrastructure it seemed simplest to copy the subset of the Mersenne Twister code we use into MOM_random. Moving forward we are expecting a state-free random number generater that will eventually displace the Mersenne Twister.
|
This PR has passed the pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11946 . |
Hallberg-NOAA
approved these changes
Jan 27, 2021
|
All,
While I understand that one of the goals of MOM6 as a community
infrastructure is to disentangle from explicit dependencies on FMS, I'd
like to point out that "shared utilities" (e.g. time manager, random
number generators) are part of the GFDL coupled model community that
rely on MOM6. I hope that your implementation does not make it difficult
to use a shared random number generator if that is what a coupled model
chooses to do.
Just an observation.
thanks
jeff
…On 1/27/21 9:02 AM, Robert Hallberg wrote:
***@***.**** approved this pull request.
I agree that importing the MersenneTwister code into MOM_random.F90 is
the right thing to do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/NOAA-GFDL/MOM6/pull/1300#pullrequestreview-577365198>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXB2AACNKTULOBA5YB2WD3S4AMITANCNFSM4WUIZO5Q>.
--
Jeff Durachta, PhD
Pronouns: he/him/his
Engineering Lead for Modeling Systems
NOAA Geophysical Fluid Dynamics Lab
Forrestal Campus, Princeton University
201 Forrestal Road
Princeton, NJ 08540
Office: +1-609-987-5054
|
|
Yes, we recognize that we need to use the same types as the framework compatibility, and shared code to avoid redundancy. The random module was not being used in conjunction with any other part of the coupled system but for an interior process that is not yet in regular use. As mentioned in the PR, we have a stateless RNG coming soon and we plan to phase out our use of the Mersenne Twister which uses significant memory the way we've been needing to use it - I think we were using it in a way it was intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random number generator was not really infrastructure code but shared code. Since we are making MOM6 agnostic to the version of infrastructure it seemed simplest to copy the subset of the Mersenne Twister code we use into MOM_random. Moving forward we are expecting a state-free random number generator that will eventually displace the Mersenne Twister.