MOM6: +Document MOM_io routines #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed module use statements for unused subroutines from MOM_io of for the entire netcdf module. All answers are bitwise identical.
Added explicit interfaces to field_size, check_nml_error, open_namelist_file, write_version_number and get_filename_appendix to MOM_io.F90. Added explicit interfaces to write_metadata, get_file_times, get_axis_data and get_file_times as well as the newly named routines check_namelist_error, check_namelist_error, write_version, get_field_size to MOM_io_infra.F90. MOM_read_data was expanded to work with regions of 2D fields. MOM_grid_initialize and MOM_restart were altered to use the new interfaces, and support for non-domain-decomposed 2-d, 3-d and 4-d arrays was dropped from the MOM_restart module. All answers are bitwise identical, but there are some expanded capabilities.
Modified the module use statements for netcdf to explicitly list the routines and constants that are used. Also added comments documenting the purpose of the encoding constants that MOM_io makes available. Also added a missing NF90_close call to Surface_Bands_by_data_override. All answers are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1301 +/- ##
============================================
+ Coverage 45.91% 45.93% +0.01%
============================================
Files 233 233
Lines 71995 72052 +57
============================================
+ Hits 33058 33094 +36
- Misses 38937 38958 +21
Continue to review full report at Codecov.
|
adcroft
reviewed
Jan 27, 2021
adcroft
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11948 completed and passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a commits that completes the documentation of the interfaces
for all routines that are accessed via MOM_io.F90 and MOM_io_infra.F90. There
are some localized changes to I/O interfaces to better fit with their use in
MOM6. All answers and output files are bitwise identical. The commits in this
PR include: