Included array_global_min_man in MOM_generic_tracer.F90 #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included a copy of mpp_array_global_min_man from mpp_utilities in MOM_generic_tracer.F90 as array_global_min_max to document what had been an interface from mpp that is used in MOM6, and to break a dependence on a part of the FMS code. There are a number of serious problems with this routine, both with it reporting values that are incorrect and with it failing most forms of self-consistency testing. But rather than fixing any of these problems, they are noted in comments, and this is an exact reproduction of its predecessor.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1319 +/- ##
============================================
- Coverage 45.79% 45.76% -0.04%
============================================
Files 234 234
Lines 72476 72527 +51
============================================
Hits 33194 33194
- Misses 39282 39333 +51
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included a copy of mpp_array_global_min_max from mpp_utilities in
MOM_generic_tracer.F90 as array_global_min_max to document what had been an
interface from mpp that is used in MOM6, and to break a dependence on a part of
the FMS code. There are a number of serious problems with this routine, both
with it reporting values that are incorrect and with it failing most forms of
self-consistency testing. But rather than fixing any of these problems, they
are noted in comments, and this is an exact reproduction of its predecessor.