Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prevent divide by zero in future version of mstar #994

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

wfcooke
Copy link
Contributor

@wfcooke wfcooke commented Sep 5, 2019

Also standardizing capitalization of names of some variables (MStar vs mstar)

Also standardizing capitalization of names of some variables (MStar vs mstar)
@codecov-io
Copy link

codecov-io commented Sep 5, 2019

Codecov Report

Merging #994 into dev/gfdl will decrease coverage by <.01%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl     #994      +/-   ##
============================================
- Coverage     43.24%   43.24%   -0.01%     
============================================
  Files           213      213              
  Lines         62214    62216       +2     
============================================
  Hits          26905    26905              
- Misses        35309    35311       +2
Impacted Files Coverage Δ
...c/parameterizations/vertical/MOM_energetic_PBL.F90 66.46% <7.69%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f790eb...453f859. Read the comment docs.

Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the logic with this change. It remains a mystery to me why the product of MStar and UStar should be zero in an ocean cell, although this was obviously what was happening at the beginning of the SPEAR test cases where @wfcooke was encountering the problems.

I also appreciate the changes for more consistent capitalization of variables. Assuming that this passes the pipeline tests, this PR should be accepted.

@Hallberg-NOAA
Copy link
Collaborator

The pipeline testing this PR has passed at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/pipelines/8860.

@Hallberg-NOAA Hallberg-NOAA merged commit d565cf6 into mom-ocean:dev/gfdl Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants