Fix unit test failures on gh-actions #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vincerubinetti
requested review from
glass-ships and
falquaddoomi
and removed request for
glass-ships
falquaddoomi
approved these changes
Sep 12, 2023
| @@ -38,6 +38,7 @@ export const apiCall = async (): Promise<void> => { | |||
| */ | |||
| await sleep(); | |||
| await sleep(); | |||
| await sleep(10); | |||
There was a problem hiding this comment.
Perhaps a comment here about why it's 10 seconds, in addition to the two non-parameterized calls above, would be nice.
There was a problem hiding this comment.
Unfortunately, the 10ms is arbitrary and I really don't know why the error is happening. I can't replicate it locally.
I'll add a generic comment to this effect, also leave this PR open a little longer (maybe til next week) to keep investigating.
|
Merging this so PRs stop failing, but I'm setting a reminder for myself to keep investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apiCallutil call due to unknown cause. add arbitrary timeout (see issue linked in code comment) in lieu of adding whole new package@testing-library/vuejust for one functionwaitForand rewriting all unit tests that useapiCall.