tweak unit test setup funcs #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
glass-ships
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #315
I've done extensive testing with tmate on github actions, messing with sleep locations/counts, package versions, test setup/teardown, logging at various places, etc. I also managed to reproduce the bug locally, seemingly by updating all packages, clearing yarn cache, and reinstalling (even though I'm fairly sure I did this before).
I'm more certain now that the error is due to
mswarbitrarily wrapping things in promises. Now the magic number of sleeps seems to be 3, and may need to be increased in the future depending onmswimplementation details. I've added a comment about this. I've also determined I could get rid of some test setup/teardown functions.