Simplify loading of converter in CurieService #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app canceled.
|
|
@glass-ships can you approve this for CI? |
|
(we can ignore the unit test failing, it's unrelated and i believe vince is already looking into it) |
glass-ships
approved these changes
Dec 1, 2023
glass-ships
added a commit
that referenced
this pull request
Dec 17, 2023
This PR follows up on #486 by fully replacing the CuriesService class and all functionality that makes thin wrappers around `curies.Converter` with direct usage. --------- Co-authored-by: Glass <glass.ships@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses newer code from
prefixmapsthat directly instantiates a converter