Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Teams Page again #487

Merged
merged 22 commits into from
Dec 12, 2023
Merged

Updating Teams Page again #487

merged 22 commits into from
Dec 12, 2023

Conversation

glass-ships
Copy link
Collaborator

@glass-ships glass-ships commented Nov 29, 2023

Closes #489, #74, #304 and #399

  • still need links, roles, and pics for several members
  • could probably use better images for SAB
  • may need help removing default profile pictures for alumni (if possible), just turning into a text list or table

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 93fd590
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6578aa901a9ce60008fc6784
😎 Deploy Preview https://deploy-preview-487--monarch-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@glass-ships glass-ships changed the title first pass at adding SAB and removing alumni links and pics Updating Teams Page again Nov 29, 2023
@glass-ships
Copy link
Collaborator Author

thanks for looking at the tests @vincerubinetti !
also wondering, what would be your recommended approach to the last checkbox in the pinned comment?

@vincerubinetti
Copy link
Contributor

I implemented that in that last commit, I just added a noImage param to the AppMember component.

@glass-ships
Copy link
Collaborator Author

oh awesome!! you're the best, thanks man

@vincerubinetti
Copy link
Contributor

Still working on fixing the unit test. It doesn't fail for me locally.

@vincerubinetti
Copy link
Contributor

Well I really can't figure out right now why unit is failing on gh-actions but not locally. document should be defined because the unit tests run in the jsdom environment which replicates the browser. So I just added a check for if doc is defined.

Playing around with the package versions, I think it's probably some kind of weird version compatibility bug. So this may be fixed by upgrading all the packages in the future (I want to do this in the next few months as a separate dedicated PR).

@sagehrke
Copy link
Member

@glass-ships Minor updates, and then I can approve:

  • Damian Smedley's Role should be updated to Monarch PI
  • Remove Chris Chute's Role (just leave it blank)

All the rest is good! We will follow up in the coming month to chase after any missing content. Thank you!

@glass-ships glass-ships merged commit d5a6124 into main Dec 12, 2023
10 checks passed
@glass-ships glass-ships deleted the team-page branch December 12, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Team Page on UI - summary of all changes
3 participants