Update typer #885
Merged
Update typer #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 4, 2024 12:32
This is a rather large commit, but should not change any functionality. First and foremost, all options and arguments are defined using the typing.Annotated API introduced in typer 0.9.0, which is the recommended way to use the library: <https://typer.tiangolo.com/release-notes/#090> That means that this argument: foo: str = typer.Argument("default value", "--foo", "-f") Becomes this: foo = Annotated[ str, typer.Argument("--foo","-f") ] = "default value" The Annotated API was already being used in the CLI, but was silently failing because we were using an older version of Typer that didn't support it. Second, the Google-style argument documentation in docstrings was taken out, as those field descriptions are generated by typer automatically. Finally, this commit also removes the typer-cli dependency, as it is deprecated and its functionality is included in typer itself.
Instead of duplicating the exact function signature and then calling out to the solr_cli functions, just register them using `app.command` (without the function decorator syntax)
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 91 91
Lines 3136 3136
=======================================
Hits 2236 2236
Misses 900 900 ☔ View full report in Codecov by Sentry. |
kevinschaper
approved these changes
Nov 7, 2024
|
oops, sorry, I thought I had approved this already - thank you so much for the cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
typerto 0.12.0AnnotatedAPIcli.pythat are also insolr_cli.pyChecks