Eliminate use of v-html when rendering node names and descriptions #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 18, 2024 14:58
Needed for fixing #902.
Instead of building up a DOM tree from scratch, instead find the strings matching opening and closing tags, and then surround the contents inside them. This allows nesting tags within one another. (There were several cases where <sup> tags had nested <i> tags). Additionally, following the Vue style guide, use hyphen-case for template attributes.
Additionally, update documentation.
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevinschaper
approved these changes
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 71.37% 71.14% -0.24%
==========================================
Files 91 91
Lines 3148 3136 -12
==========================================
- Hits 2247 2231 -16
- Misses 901 905 +4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
added 2 commits
November 20, 2024 15:22
The iterator helpers standard is accepted as part of EcmaScript, but not yet universally implemented. <https://github.com/tc39/proposal-iterator-helpers> <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Iterator/forEach>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Summary
<AppNodeText>which safely renders text containing<i>,<sup>, and<a>tags, while also leaving arbitrary text <enclosed in brackets> untouched.v-htmldirective when rendering nodes, replacing it with<AppNodeText>Checks