-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiselect component #354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orrgottlieb
requested changes
Dec 1, 2021
src/components/Dropdown/components/ValueContainer/ValueContainer.jsx
Outdated
Show resolved
Hide resolved
orrgottlieb
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Change
Add support for multiple values to our
<Dropdown>
component, via the following new props:multi
- When passed, will render selected options as chips.multiline
- When passed, and the component is constrained with a specific width, will cause it to drop line instead of displaying a counter of unrendered chips.onOptionRemove
- Will be called whenever a chip’s “X” is clicked.onOptionSelect
- Will be called whenever an option is clicked inside the menu.onClear
- Will be called whenever the generic clear button is clicked.Additional Changes
Infrastructure
<Dropdown>
isOpen
prop from<Menu>
.<Chips>
data-testid
.<Counter>
onMouseDown
prop, needed to prevent<Dropdown>
from opening the menu when the counter is clicked.<Dialog>
open
prop, which caused it to be “ignored” when the component’s internal state changes.<Tooltip>
to this component.<Icon>
data-testid
.