Fix drop down counter in multi state with single line #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 30, 2022 17:36
hadasfa
commented
Jan 31, 2022
| ### Close dropdown with multi choose | ||
| Pass closeMenuOnSelect to close the multi choose any time an options is chosen. | ||
| ### Multi line states | ||
| Drop down component support multiple options selection in two different state - single line and multiple lines |
There was a problem hiding this comment.
replace story to more readable and helpful one about multi state
sahariko
reviewed
Jan 31, 2022
| @@ -0,0 +1,31 @@ | |||
| import { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
This file can be simply named hooks, since we're in the context of ValueContainer already.
There was a problem hiding this comment.
change it as in other components (directory of hooks and a file for each hook)
src/components/Dropdown/components/ValueContainer/ValueContainerHooks.js
Outdated
Show resolved
Hide resolved
src/components/Dropdown/components/ValueContainer/ValueContainerHooks.js
Outdated
Show resolved
Hide resolved
src/components/Dropdown/components/ValueContainer/ValueContainerHooks.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Sahar Brodbeker <saharonb@gmail.com>
Co-authored-by: Sahar Brodbeker <saharonb@gmail.com>
…erHooks.js Co-authored-by: Sahar Brodbeker <saharonb@gmail.com>
…erHooks.js Co-authored-by: Sahar Brodbeker <saharonb@gmail.com>
…-react-core into bugs/hadas/dropdown2
sahariko
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic
npm run plop) to create a new component.PropTypes.Style
NewComponent.modules.scssfile inside of theNewComponentfolder.Storybook
/src/NewComponent/__stories__/NewComponent.stories.jsfile.Tests