Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added menuPlacement prop to Dropdown component #561

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Added menuPlacement prop to Dropdown component #561

merged 1 commit into from
Mar 1, 2022

Conversation

udidoron
Copy link
Contributor

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component defines PropTypes.

Style

  • Styles are added to NewComponent.modules.scss file inside of the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.

Storybook

  • Stories were added to /src/NewComponent/__stories__/NewComponent.stories.js file.
  • Stories include all flows of using the component.

Tests

@orrgottlieb orrgottlieb merged commit 61510c1 into mondaycom:master Mar 1, 2022
@udidoron udidoron deleted the fix/udi/dropdown-allow-menu-placement branch March 1, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MosheZemah MosheZemah MosheZemah approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@udidoron @MosheZemah @orrgottlieb