From 66387fad30dd016c892a8c8307159014b8d77888 Mon Sep 17 00:00:00 2001
From: Christoph Hartmann <chris@lollyrock.com>
Date: Mon, 3 Jun 2024 21:09:00 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=B9=20update=20shodan=20lr=20descripti?=
 =?UTF-8?q?ons=20(#4174)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* 🧹 update shodan lr descriptions

* Update providers/shodan/resources/shodan.lr

---------

Co-authored-by: Tim Smith <tsmith84@gmail.com>
---
 providers/os/resources/os.lr.manifest.yaml |  3 +++
 providers/shodan/resources/shodan.lr       | 10 ++++++++++
 2 files changed, 13 insertions(+)

diff --git a/providers/os/resources/os.lr.manifest.yaml b/providers/os/resources/os.lr.manifest.yaml
index 38bbd4ec8a..b99c10ec3d 100644
--- a/providers/os/resources/os.lr.manifest.yaml
+++ b/providers/os/resources/os.lr.manifest.yaml
@@ -1096,6 +1096,7 @@ resources:
       installed: {}
       name: {}
       path: {}
+    is_private: true
     min_mondoo_version: 5.15.0
     snippets:
     - query: windows.feature('SNMP-Service').installed
@@ -1169,6 +1170,7 @@ resources:
       enabled: {}
       name: {}
       state: {}
+    is_private: true
     min_mondoo_version: 9.0.0
   windows.security:
     fields:
@@ -1203,6 +1205,7 @@ resources:
       installed: {}
       name: {}
       path: {}
+    is_private: true
     min_mondoo_version: 9.0.0
   yaml.path:
     fields:
diff --git a/providers/shodan/resources/shodan.lr b/providers/shodan/resources/shodan.lr
index a4d36bfcb4..93a55570a8 100644
--- a/providers/shodan/resources/shodan.lr
+++ b/providers/shodan/resources/shodan.lr
@@ -59,18 +59,28 @@ private shodan.nsrecord @defaults("domain subdomain type") {
 
 // Shodan Search Engine account
 shodan.profile @defaults("displayName"){
+  // Indicates if the account is a member
   member bool
+  // Number of search credits
   credits int
+  // Display name
   displayName string
+  // Profile creation time
   createdAt time
 }
 
 // Shodan Search Engine API plan information
 shodan.apiPlan @defaults("plan"){
+  // Number of scan credits
   scanCredits int
+  // Name of the plan
   plan string
+  // Indicates if the plan is active
   unlocked bool
+  // Number of scan credits left
   unlockedLeft int
+  // Indicated if Telnet is allowed
   telnet bool
+  // Number of monitored IPs
   monitoredIps int
 }
\ No newline at end of file