-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Chunk sending results by size #1440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think we have similar code in cnquery though. It may be a better idea to define the chunking there so we can re-use it in both cnquery and cnspec
6c02359
to
fe532b8
Compare
Do you have specific code in mind? |
790d1da
to
02251a6
Compare
02251a6
to
47b4bca
Compare
There is an upper limit to what is accepted by the platform per request. Make sure we do not go past it when sending data.
47b4bca
to
a5a7734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is an upper limit to what is accepted by the platform per request. Make sure we do not go past it when sending data.