This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Allow multiple watch paths for single target #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquick
reviewed
Jan 29, 2019
Sometimes you'll want to trigger a single pipeline based on multiple paths not sharing a common root. This change allows you to specify an array of paths to watch for a single target in addition to preserving the old behavior of a single string. I believe this change also unsurfaced a bug with the existing diff tests where `buildkite-agent pipeline upload` was expected to be called in the tests but shouldn't acutally be called based on the code in the command hook. Signed-off-by: Elliott Davis <elliott@excellent.io>
jquick
approved these changes
Jan 29, 2019
|
Thanks @elliott-davis! 👋 |
|
@all-contributors please add @elliott-davis for code, test and idea |
|
I've put up a pull request to add @elliott-davis! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes you'll want to trigger a single pipeline based on multiple
paths not sharing a common root. This change allows you to specify
an array of paths to watch for a single target in addition to preserving
the old behavior of a single string.
I believe this change also unsurfaced a bug with the existing diff tests
where
buildkite-agent pipeline uploadwas expected to be called in thetests but shouldn't acutally be called based on the code in the command
hook.
Signed-off-by: Elliott Davis elliott@excellent.io