Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Checking submodules" for miniupnp, unbound, and rapidjson during make states "No such file or directory" when these directories exist #4616

Closed
mmortal03 opened this issue Oct 16, 2018 · 5 comments
Labels

Comments

@mmortal03
Copy link

When making either Monero master or v0.13.0.3 on Windows in MSYS2 MinGW 64-bit (for instance, by running: make -j9 release-static-win64), I get the following output, even though these submodule directories properly exist (from having previously run a fresh: git clone --recursive https://github.com/monero-project/monero)

-- Checking submodules
/bin/bash: line 0: cd: C:/msys64/home/mmortal03/monero/external/miniupnp: No such file or directory
/bin/bash: line 0: cd: C:/msys64/home/mmortal03/monero/external/unbound: No such file or directory
/bin/bash: line 0: cd: C:/msys64/home/mmortal03/monero/external/rapidjson: No such file or directory

In spite of this, I can still compile v0.13.0.3, so there's seemingly just something superficially wrong with the submodule checking syntax?

Testing the command from CMakeLists.txt outside of the make process directly on the MSYS2 commandline produces a result, not an error, so it's probably just something wrong with the syntax?

For example, running the following command results in no output from the part before the Boolean operator, and the proper result of the git command from after the Boolean operator:

bash -c "cd C:/msys64/home/mmortal03/monero/external/miniupnp && git rev-parse HEAD"

@moneromooo-monero
Copy link
Collaborator

moneromooo-monero commented Oct 16, 2018

Do you see files with this ? ls C:/msys64/home/mmortal03/monero/external/miniupnp Nevermind, your last sentence implies there are.

@mmortal03
Copy link
Author

This will be fixed once #4620 is merged. Closing.

@xiphon
Copy link
Contributor

xiphon commented Oct 21, 2018

@mmortal03
PS: I think you don't have to close the issue before it gets merged

@mmortal03
Copy link
Author

I just didn't want to forget to close it later, but for discoverability reasons (others noticing the same thing) maybe it should stay open until it gets merged.

@mmortal03 mmortal03 reopened this Oct 21, 2018
@moneromooo-monero
Copy link
Collaborator

+resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants