[RELEASE] Unbound: bump to 1.7.0rc3 + remove in-tree source, use git submodule

[anonimal]

As approved by @moneromooo-monero on IRC, still open for consideration: here is the concept of what we should consider doing for all our external dependencies.

To consider:

• I wish to immediately move https://github.com/anonimal/unbound into monero-project, thus stripping any of my write access to the repo
• I've kept things simple regarding svn to git: no trunk/branch/tag conversions, no prettying of git log. This has proven to make things easier when we git svn rebase; especially because we are working from a custom branch and we will need to rebase for every unbound release.

Referencing #2089 (comment)

[moneromooo-monero]

Approved in principle, BUT github does not seem to show the patch setting the commit hash for the submodule, it shows some dodgy looking preparsed link, so it's hard to see what the patch actully is for that (pretty important) part. I think it should be merged only after the URL target switches to monero-project though, even with a set hash.

[anonimal]

github does not seem to show the patch setting the commit hash for the submodule, it shows some dodgy looking preparsed link

Yes, it's annoying, but it appears to be accurate. I'm guessing the only other way to verify with confidence (until github fixes, if ever) will be to fetch branch monero from my fork to confirm the commit. I'm thinking people will be doing this anyway, so that's good.

I think it should be merged only after the URL target switches to monero-project

As soon as @fluffypony et al creates monero-project/unbound, I'll move my repo over a.s.a.p.

[fluffypony]

@anonimal created https://github.com/monero-project/unbound

[anonimal]

@fluffypony rebased. I don't have push access to monero-project/unbound (at least temporarily to get my repo moved) so the code will have to get there somehow before this PR is merged.

[fluffypony]

@anonimal can't you PR to that? or must I initialise with a readme for that to work?

[anonimal]

can't you PR to that?

Nope. I tried. AFAICT the repo needs to be pushed directly. Ideally (in fact, we probably shouldn't) you don't initialize a README or any file because master will be the pure svn-to-git of unbound and having our own commit will make things a pain to deal with IMHO.

[anonimal]

Successfully pushed to https://github.com/monero-project/unbound.

[danrmiller]

Works for me on linux, windows, freebsd, and mac, and the changes appear to do what the title claims.

[hyc]

We'll definitely need a pristine branch for syncing from upstream, but also a monero-specific branch for any point patches we need to apply.

[danrmiller]

This submodule already uses the "monero" branch from https://github.com/monero-project/unbound/tree/monero.

We should verify that everything we need is in there and PR what's missing. It looks like many things, for example 45e9838, are already included upstream.

For the "clean" branch, I'll check out upstream with subversion and verify, but it looks like we are tracking trunk. Should we pick a tag instead like either the latest 1.6.7 or the 1.6.3 we were previously using? Or do the differences between svn and git make that not practical?

[moneromooo-monero]

Is there anything I can help with here ?

[anonimal]

Oops, forgot that I opened this PR. When someone gives me the go-ahead, I'll rebase. I'm not sure if @danrmiller had a chance to verify.

Or do the differences between svn and git make that not practical?

AFAICT, and IIRC, not practical (but maybe someone else has input on that).

[anonimal]

Ping @danrmiller

[danrmiller]

@anonimal What would you like me to do? I don't have anything to add since last time.

[anonimal]

@danrmiller ok, thanks for clarifying.

I've opened monero-project/unbound#1 and monero-project/unbound#2. After they are merged, this PR will resolve #3413 (@fluffypony I can't rebase this PR until those are merged).

[anonimal]

Note: this PR was marked for release because the in-tree unbound is outdated at 1.6.3. The current 1.7.0rc3 is the latest stable version and is the tag used in their March 15th, release.

[fluffypony]

Reviewed