Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis to Monero with the depends toolchain. #4420

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

TheCharlatan
Copy link
Contributor

This adds Travis CI to Monero. I do this in full awareness that there is an existing build bot, which is much more advanced than this quite simple CI config, but there are some advantages to this setup.

  • Makes it transparent which dependencies and versions thereof are guaranteed to be supported.
  • Cross compiles to a bunch of targets as well, like the current build bot.
  • Runs the CI even on you own branches, if you activate it. This means for example that when you are developing on windows 64 bit, you do not need to open a pull request for the current build bot to tell you that on arm 32 bit, you are missing macro definitions in your patch. Travis CI will catch this, when you push to your own remote on github.

The builds for windows and mac are still failing because pcsc cannot be cross compiled. 32 bit Linux is also failing, I may need some assistance here on how to get libblocks compiled correctly for the i686 architecture. I am waiting for the hid pr to be merged to fix that as well.

Add a Travis build script for Monero. This was blatantly copied from
Bitcoin. It spawns jobs in docker containers running an ubuntu bionic
image.

This commit also a fixes a problem where librt was still linked, even
when compiling statically.
Clang needs to get its cctools path passed.
@TheCharlatan TheCharlatan changed the title Depends travis Add Travis to Monero with the depends toolchain. Sep 22, 2018
@TheCharlatan TheCharlatan changed the title Add Travis to Monero with the depends toolchain. [Do not merge] Add Travis to Monero with the depends toolchain. Sep 22, 2018
@TheCharlatan
Copy link
Contributor Author

The repository maintainers need to activate it on https://travis-ci.org/ , if this is a desired feature.

@TheCharlatan TheCharlatan changed the title [Do not merge] Add Travis to Monero with the depends toolchain. Add Travis to Monero with the depends toolchain. Sep 23, 2018
$(package)_download_path=https://github.com/jedisct1/libsodium/archive
$(package)_file_name=$($(package)_version).tar.gz
$(package)_sha256_hash=0c14604bbeab2e82a803215d65c3b6e74bb28291aaee6236d65c699ccfe1a98c
$(package)_version=1.0.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to downgrade libsodium ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get that version to play nice with the darwin build. If it is a problem, and there is a reason for taking 1.0.16 , I'll try to get it running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if it's a problem, just curiosity.

@xiphon
Copy link
Contributor

xiphon commented Sep 24, 2018

32 bit Linux is also failing, I may need some assistance here on how to get libblocks compiled correctly for the i686 architecture.

Working on it. Implementing architecture-independent approach.

Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit 0f4f873 into monero-project:master Sep 25, 2018
fluffypony added a commit that referenced this pull request Sep 25, 2018
0f4f873 Fix Darwin Sodium build (TheCharlatan)
bf1e1d9 A Travis to monero (TheCharlatan)
@TheCharlatan TheCharlatan deleted the DependsTravis branch October 17, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants