Add hidapi to depends #4431
Merged
Add hidapi to depends #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis build results can be seen here: https://travis-ci.org/TheCharlatan/monero/builds/432681811?utm_source=github_status&utm_medium=notification |
|
Please rebase, looks like 4420 was included in this PR |
|
...as stated in the pr description. I'll pull over the changes from 4420 then. That should fix the apple build and leave 4420 with just the travis addition. |
|
@TheCharlatan I did merge 4420 first, per the description, but it's conflicting despite that |
Clang needs to get its cctools path passed directly for the hid build to succeed. Make gperf a permanent external dependency. Remove pcsc from depends.
TheCharlatan
force-pushed
the
dependsHID
branch
from
e324866 to
5c234cb
Compare
|
Weird, I first got the notification of your message, then only the merge notice of 4420. Sorry for the confusion. |
fluffypony
added a commit
that referenced
this pull request
Sep 25, 2018
5c234cb Add hidapi to depends (TheCharlatan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is based on #4420 , please merge that first.
The hidapi library is easily cross compiled to windows and mac, so this should fix the depends builds for mac and windows. I have not tested the produced binaries for Ledger Support, this should be probably be done at some point.