Fix boost <1.60 compilation and fix boost 1.73+ warnings #6612
Conversation
| @@ -31,7 +31,7 @@ | |||
|
|
|||
|
|
|||
| #include <boost/thread.hpp> | |||
| #include <boost/bind.hpp> | |||
| #include <boost/bind/bind.hpp> | |||
There was a problem hiding this comment.
boost bind still ?
There was a problem hiding this comment.
There are 88 occurrences of boost::bind, outside of the usage in src/simplewallet/simplewallet.cpp. There are 120 occurrences in just that file. I decided to only update the places that used _1, etc, to keep this smaller and readable. Updating the remaining seemed like it could be done in a subsequent patch, but I can do a sed call right now and re-test the compilations ... ? With or without updating simplewallet.cpp.
There was a problem hiding this comment.
Update - only 39 of 88 are from in src/ but outside of src/simplewallet/simplewallet.cpp. Meaning, some of the stuff in contrib is dead unused/code I think, so I may not need to update all 88 occurrences. Its difficult to know how many without trial and error though.
There was a problem hiding this comment.
Makes sense. I'm in favour of leaving it as is if it doesn't need fixing :)
| @@ -31,7 +31,7 @@ | |||
| // IP blocking adapted from Boolberry | |||
|
|
|||
| #include <algorithm> | |||
| #include <boost/bind.hpp> | |||
| #include <boost/bind/bind.hpp> | |||
missed some spots
followed commit monero-project#6612 on xmr
This fixes the build with Boost 1.58 and fixes all warnings with Boost 1.73+ (by including
boost/bind/bind.hpp). Onlysrc/simple/simplewallet.cppstill uses the global_1variables.The differences between
std::bindandboost::bind.