This repository was archived by the owner on Feb 4, 2022. It is now read-only.
fix(mongos): fix connection leak when mongos reconnects #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprahamian
force-pushed
the
NODE-1403/stop-connection-leak
branch
from
abe0191 to
284e8bc
Compare
Our mongos reconnect logic involved creating a new Server+Pool per proxy per iteration of the reconnect logic. These instances were never cleaned up, resulting in a huge number of connections when the proxies finally reconnected. Fixes NODE-1403
daprahamian
force-pushed
the
NODE-1403/stop-connection-leak
branch
from
284e8bc to
2d47126
Compare
daprahamian
changed the title
mbroadst
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our mongos reconnect logic involved creating a new Server+Pool
per proxy per iteration of the reconnect logic. These instances
were never cleaned up, resulting in a huge number of connections
when the proxies finally reconnected.
Fixes NODE-1403
WIP b/c I am trying to figure out how to test this.I have a test now. It takes a long time though :(