From 3a962aa2640126051477ab0f60c38caad4cf206e Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 10:56:23 -0600 Subject: [PATCH 01/15] add sarif report generation --- .github/workflows/codeql.yml | 5 --- .github/workflows/release.yml | 59 ++++++++++++++++++++++++++++------- 2 files changed, 48 insertions(+), 16 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 04fe867c..29d6f82f 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -9,11 +9,6 @@ on: jobs: analyze: name: Analyze (${{ matrix.language }} - ${{ matrix.identifier }}) - # Runner size impacts CodeQL analysis time. To learn more, please see: - # - https://gh.io/recommended-hardware-resources-for-running-codeql - # - https://gh.io/supported-runners-and-hardware-resources - # - https://gh.io/using-larger-runners (GitHub.com only) - # Consider using larger runners or machines with greater resources for possible analysis time improvements. runs-on: 'ubuntu-latest' timeout-minutes: 360 permissions: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 16068041..c1c9c043 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,20 +19,57 @@ jobs: - id: release uses: google-github-actions/release-please-action@v4 - compress_sign_and_upload: - needs: [release_please] + # compress_sign_and_upload: + # needs: [release_please] + # if: ${{ needs.release_please.outputs.release_created }} + # runs-on: ubuntu-latest + # steps: + # - uses: actions/checkout@v4 + # - name: actions/setup + # uses: ./.github/actions/setup + # - name: actions/compress_sign_and_upload + # uses: ./.github/actions/compress_sign_and_upload + # with: + # garasign_username: ${{ secrets.GRS_CONFIG_USER1_USERNAME }} + # garasign_password: ${{ secrets.GRS_CONFIG_USER1_PASSWORD }} + # artifactory_username: ${{ secrets.ARTIFACTORY_USER }} + # artifactory_password: ${{ secrets.ARTIFACTORY_PASSWORD }} + # - run: npm publish --provenance + # env: + # NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + + generate_sarif_report: + environment: release runs-on: ubuntu-latest + permissions: + # required for all workflows + security-events: write + id-token: write + contents: write + steps: - uses: actions/checkout@v4 - name: actions/setup uses: ./.github/actions/setup - - name: actions/compress_sign_and_upload - uses: ./.github/actions/compress_sign_and_upload + - name: Set up drivers-github-tools + uses: mongodb-labs/drivers-github-tools/setup@v2 with: - garasign_username: ${{ secrets.GRS_CONFIG_USER1_USERNAME }} - garasign_password: ${{ secrets.GRS_CONFIG_USER1_PASSWORD }} - artifactory_username: ${{ secrets.ARTIFACTORY_USER }} - artifactory_password: ${{ secrets.ARTIFACTORY_PASSWORD }} - - run: npm publish --provenance - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + aws_region_name: us-east-1 + aws_role_arn: ${{ secrets.aws_role_arn }} + aws_secret_id: ${{ secrets.aws_secret_id }} + + - name: "Generate Sarif Report" + uses: "alcaeus/drivers-github-tools/code-scanning-export@export-code-scanning-report" + with: + ref: main + output-file: sarif-report.json + + - name: "Move sarif report to output file" + shell: bash + run: cp sarif-report.json ${{ env.S3_ASSETS }}/sarif-report.json + + - name: 'Print (TODO - upload to s3 instead)' + shell: bash + run: | + ls ${{ env.S3_ASSETS }} + cat ${{ env.S3_ASSETS }}/sarif-report.json From e0ad0184768c257204601a99f973d92bfa7dc736 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 13:51:59 -0600 Subject: [PATCH 02/15] add upload to s3 capability --- .../actions/publish_asset_to_s3/action.yml | 38 +++++++++++++++++++ .github/workflows/release.yml | 8 ++++ 2 files changed, 46 insertions(+) create mode 100644 .github/actions/publish_asset_to_s3/action.yml diff --git a/.github/actions/publish_asset_to_s3/action.yml b/.github/actions/publish_asset_to_s3/action.yml new file mode 100644 index 00000000..0c515d8d --- /dev/null +++ b/.github/actions/publish_asset_to_s3/action.yml @@ -0,0 +1,38 @@ + +name: Publish Python +description: "Publish Assets and Report" +inputs: + version: + description: "The published version" + required: true + product_name: + description: "The name of the product" + required: true + files: + description: file to upload + required: true + dry_run: + description: "Whether this is a dry run" + required: true + +runs: + using: composite + steps: + - name: Run publish script + shell: bash + run: | + set -eux + if [ "$DRY_RUN" == "false" ]; then + echo "Uploading Release Reports" + TARGET=s3://${AWS_BUCKET}/${PRODUCT_NAME}/${VERSION} + aws s3 cp $FILES $TARGET + else + echo "Dry run, not uploading to S3 or creating GitHub Release" + echo "Would upload $FILES" + fi + env: + VERSION: ${{ inputs.version }} + PRODUCT_NAME: ${{ inputs.product_name }} + DRY_RUN: ${{ inputs.dry_run }} + FILES: ${{ inputs.files }} + \ No newline at end of file diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index c1c9c043..81c32d47 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -73,3 +73,11 @@ jobs: run: | ls ${{ env.S3_ASSETS }} cat ${{ env.S3_ASSETS }}/sarif-report.json + + - name: actions/publish_asset_to_s3 + uses: ./.github/actions/publish_asset_to_s3 + with: + version: v6.5.0 + product_name: js-bson-development + files: sarif-report.json + dry_run: false From 9b004e76f7f35b85a5aff2e33f3e2b01debdb66d Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 13:55:14 -0600 Subject: [PATCH 03/15] add upload to s3 capability --- .github/actions/publish_asset_to_s3/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/publish_asset_to_s3/action.yml b/.github/actions/publish_asset_to_s3/action.yml index 0c515d8d..ece80af9 100644 --- a/.github/actions/publish_asset_to_s3/action.yml +++ b/.github/actions/publish_asset_to_s3/action.yml @@ -24,7 +24,7 @@ runs: set -eux if [ "$DRY_RUN" == "false" ]; then echo "Uploading Release Reports" - TARGET=s3://${AWS_BUCKET}/${PRODUCT_NAME}/${VERSION} + TARGET=s3://${AWS_BUCKET}/${PRODUCT_NAME}/${VERSION}/${FILES} aws s3 cp $FILES $TARGET else echo "Dry run, not uploading to S3 or creating GitHub Release" From bb256b8739291a7ed71922134274917184401178 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:02:46 -0600 Subject: [PATCH 04/15] add upload to s3 capability --- .github/actions/publish_asset_to_s3/action.yml | 8 +++++--- .github/workflows/release.yml | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/actions/publish_asset_to_s3/action.yml b/.github/actions/publish_asset_to_s3/action.yml index ece80af9..23e08e0f 100644 --- a/.github/actions/publish_asset_to_s3/action.yml +++ b/.github/actions/publish_asset_to_s3/action.yml @@ -1,6 +1,6 @@ -name: Publish Python -description: "Publish Assets and Report" +name: Publish Release Asset to S3 +description: "Publish Asset to S3" inputs: version: description: "The published version" @@ -13,7 +13,9 @@ inputs: required: true dry_run: description: "Whether this is a dry run" - required: true + required: false + type: boolean + default: false runs: using: composite diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 81c32d47..5eb7e507 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -73,11 +73,11 @@ jobs: run: | ls ${{ env.S3_ASSETS }} cat ${{ env.S3_ASSETS }}/sarif-report.json - + - name: actions/publish_asset_to_s3 uses: ./.github/actions/publish_asset_to_s3 with: version: v6.5.0 product_name: js-bson-development files: sarif-report.json - dry_run: false + dry_run: true From eade3e4c1fa26a43c6db60d5af4b3aff28b21986 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:06:37 -0600 Subject: [PATCH 05/15] add upload to s3 capability --- .github/actions/publish_asset_to_s3/action.yml | 4 ++-- .github/workflows/release.yml | 13 ++----------- 2 files changed, 4 insertions(+), 13 deletions(-) diff --git a/.github/actions/publish_asset_to_s3/action.yml b/.github/actions/publish_asset_to_s3/action.yml index 23e08e0f..6cc64d37 100644 --- a/.github/actions/publish_asset_to_s3/action.yml +++ b/.github/actions/publish_asset_to_s3/action.yml @@ -14,8 +14,7 @@ inputs: dry_run: description: "Whether this is a dry run" required: false - type: boolean - default: false + default: 'false' runs: using: composite @@ -31,6 +30,7 @@ runs: else echo "Dry run, not uploading to S3 or creating GitHub Release" echo "Would upload $FILES" + cat $FILES fi env: VERSION: ${{ inputs.version }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 5eb7e507..aa222f6f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -41,6 +41,7 @@ jobs: generate_sarif_report: environment: release runs-on: ubuntu-latest + needs: [release_please] permissions: # required for all workflows security-events: write @@ -63,16 +64,6 @@ jobs: with: ref: main output-file: sarif-report.json - - - name: "Move sarif report to output file" - shell: bash - run: cp sarif-report.json ${{ env.S3_ASSETS }}/sarif-report.json - - - name: 'Print (TODO - upload to s3 instead)' - shell: bash - run: | - ls ${{ env.S3_ASSETS }} - cat ${{ env.S3_ASSETS }}/sarif-report.json - name: actions/publish_asset_to_s3 uses: ./.github/actions/publish_asset_to_s3 @@ -80,4 +71,4 @@ jobs: version: v6.5.0 product_name: js-bson-development files: sarif-report.json - dry_run: true + dry_run: ${{ needs.release_please.outputs.release_created }} From 2ea6f55fc68905911e319b0db7d5602f10da9938 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:13:20 -0600 Subject: [PATCH 06/15] asdf --- .github/workflows/release.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index aa222f6f..a620a520 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -50,8 +50,6 @@ jobs: steps: - uses: actions/checkout@v4 - - name: actions/setup - uses: ./.github/actions/setup - name: Set up drivers-github-tools uses: mongodb-labs/drivers-github-tools/setup@v2 with: @@ -71,4 +69,4 @@ jobs: version: v6.5.0 product_name: js-bson-development files: sarif-report.json - dry_run: ${{ needs.release_please.outputs.release_created }} + dry_run: ${{ needs.release_please.outputs.release_created != '' }} From d3fe24a7333d966f96fc45464a875a0aabaf0f54 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:24:13 -0600 Subject: [PATCH 07/15] move to using shared upload action --- .../actions/publish_asset_to_s3/action.yml | 40 ------------------- .github/workflows/release.yml | 4 +- 2 files changed, 2 insertions(+), 42 deletions(-) delete mode 100644 .github/actions/publish_asset_to_s3/action.yml diff --git a/.github/actions/publish_asset_to_s3/action.yml b/.github/actions/publish_asset_to_s3/action.yml deleted file mode 100644 index 6cc64d37..00000000 --- a/.github/actions/publish_asset_to_s3/action.yml +++ /dev/null @@ -1,40 +0,0 @@ - -name: Publish Release Asset to S3 -description: "Publish Asset to S3" -inputs: - version: - description: "The published version" - required: true - product_name: - description: "The name of the product" - required: true - files: - description: file to upload - required: true - dry_run: - description: "Whether this is a dry run" - required: false - default: 'false' - -runs: - using: composite - steps: - - name: Run publish script - shell: bash - run: | - set -eux - if [ "$DRY_RUN" == "false" ]; then - echo "Uploading Release Reports" - TARGET=s3://${AWS_BUCKET}/${PRODUCT_NAME}/${VERSION}/${FILES} - aws s3 cp $FILES $TARGET - else - echo "Dry run, not uploading to S3 or creating GitHub Release" - echo "Would upload $FILES" - cat $FILES - fi - env: - VERSION: ${{ inputs.version }} - PRODUCT_NAME: ${{ inputs.product_name }} - DRY_RUN: ${{ inputs.dry_run }} - FILES: ${{ inputs.files }} - \ No newline at end of file diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index a620a520..691f759e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -64,9 +64,9 @@ jobs: output-file: sarif-report.json - name: actions/publish_asset_to_s3 - uses: ./.github/actions/publish_asset_to_s3 + uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action with: version: v6.5.0 product_name: js-bson-development files: sarif-report.json - dry_run: ${{ needs.release_please.outputs.release_created != '' }} + dry_run: ${{ needs.release_please.outputs.release_created == '' }} From bdc5f6e875abf82da1b8d966e9ddd2f4d5143afb Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:25:41 -0600 Subject: [PATCH 08/15] asdf --- .github/workflows/release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 691f759e..62914049 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -68,5 +68,5 @@ jobs: with: version: v6.5.0 product_name: js-bson-development - files: sarif-report.json + file: sarif-report.json dry_run: ${{ needs.release_please.outputs.release_created == '' }} From 62b06ca90a727613e15aed49a8956a81b76df8d6 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:29:51 -0600 Subject: [PATCH 09/15] asdf --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 62914049..999ae519 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -67,6 +67,6 @@ jobs: uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action with: version: v6.5.0 - product_name: js-bson-development + product_name: js-bson-development # TODO - adjust this file: sarif-report.json - dry_run: ${{ needs.release_please.outputs.release_created == '' }} + dry_run: ${{ needs.release_please.outputs.release_created != '' }} From 300aaa725a56cf996fe1b84132109a95397a9f91 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Thu, 30 May 2024 14:36:44 -0600 Subject: [PATCH 10/15] adjust --- .github/workflows/codeql.yml | 4 +-- .github/workflows/release-5.x.yml | 40 +++++++++++++++++++++++++ .github/workflows/release.yml | 50 ++++++++++++++++++------------- 3 files changed, 71 insertions(+), 23 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 29d6f82f..a3fbde50 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -2,9 +2,9 @@ name: "CodeQL" on: push: - branches: [ "main" ] + branches: [ "main", 5.x ] pull_request: - branches: [ "main" ] + branches: [ "main", 5.x ] jobs: analyze: diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index 88f94317..e3488b5d 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -38,3 +38,43 @@ jobs: - run: npm publish --provenance --tag=5x env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + + generate_sarif_report: + environment: release + runs-on: ubuntu-latest + needs: [release_please] + permissions: + # required for all workflows + security-events: write + id-token: write + contents: write + + steps: + - uses: actions/checkout@v4 + - name: Set up drivers-github-tools + uses: mongodb-labs/drivers-github-tools/setup@v2 + with: + aws_region_name: us-east-1 + aws_role_arn: ${{ secrets.aws_role_arn }} + aws_secret_id: ${{ secrets.aws_secret_id }} + + - name: "Generate Sarif Report" + uses: "alcaeus/drivers-github-tools/code-scanning-export@export-code-scanning-report" + with: + ref: main + output-file: sarif-report.json + + - name: Get release version and release package file name + id: get_version + shell: bash + run: | + package_version=$(jq --raw-output '.version' package.json) + echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" + + - name: actions/publish_asset_to_s3 + uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action + with: + version: ${{ steps.get_version.outputs.package_version }} + product_name: js-bson + file: sarif-report.json + dry_run: ${{ needs.release_please.outputs.release_created == '' }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 999ae519..27b5367b 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -19,24 +19,24 @@ jobs: - id: release uses: google-github-actions/release-please-action@v4 - # compress_sign_and_upload: - # needs: [release_please] - # if: ${{ needs.release_please.outputs.release_created }} - # runs-on: ubuntu-latest - # steps: - # - uses: actions/checkout@v4 - # - name: actions/setup - # uses: ./.github/actions/setup - # - name: actions/compress_sign_and_upload - # uses: ./.github/actions/compress_sign_and_upload - # with: - # garasign_username: ${{ secrets.GRS_CONFIG_USER1_USERNAME }} - # garasign_password: ${{ secrets.GRS_CONFIG_USER1_PASSWORD }} - # artifactory_username: ${{ secrets.ARTIFACTORY_USER }} - # artifactory_password: ${{ secrets.ARTIFACTORY_PASSWORD }} - # - run: npm publish --provenance - # env: - # NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} + compress_sign_and_upload: + needs: [release_please] + if: ${{ needs.release_please.outputs.release_created }} + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: actions/setup + uses: ./.github/actions/setup + - name: actions/compress_sign_and_upload + uses: ./.github/actions/compress_sign_and_upload + with: + garasign_username: ${{ secrets.GRS_CONFIG_USER1_USERNAME }} + garasign_password: ${{ secrets.GRS_CONFIG_USER1_PASSWORD }} + artifactory_username: ${{ secrets.ARTIFACTORY_USER }} + artifactory_password: ${{ secrets.ARTIFACTORY_PASSWORD }} + - run: npm publish --provenance + env: + NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} generate_sarif_report: environment: release @@ -63,10 +63,18 @@ jobs: ref: main output-file: sarif-report.json + - name: Get release version and release package file name + id: get_version + shell: bash + run: | + package_version=$(jq --raw-output '.version' package.json) + echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" + - name: actions/publish_asset_to_s3 uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action with: - version: v6.5.0 - product_name: js-bson-development # TODO - adjust this + version: ${{ steps.get_version.outputs.package_version }} + product_name: js-bson file: sarif-report.json - dry_run: ${{ needs.release_please.outputs.release_created != '' }} + dry_run: ${{ needs.release_please.outputs.release_created == '' }} + From b7de0d993f3426753dc29f7114404f1b9ce95266 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Fri, 31 May 2024 08:29:28 -0600 Subject: [PATCH 11/15] migrate off of fork --- .github/workflows/release-5.x.yml | 4 ++-- .github/workflows/release.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index e3488b5d..99405dc4 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -61,7 +61,7 @@ jobs: - name: "Generate Sarif Report" uses: "alcaeus/drivers-github-tools/code-scanning-export@export-code-scanning-report" with: - ref: main + ref: 5.x output-file: sarif-report.json - name: Get release version and release package file name @@ -72,7 +72,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action + uses: mongodb-labs/drivers-github-tools/tree/main/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 27b5367b..20e9797f 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,7 +71,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: baileympearson/drivers-github-tools/node/publish_asset_to_s3@add-upload-s3-action + uses: mongodb-labs/drivers-github-tools/tree/main/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson From 6f6467c005ecc7910ccd2b9678b1975b3c541c7c Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Fri, 31 May 2024 08:32:50 -0600 Subject: [PATCH 12/15] fix path --- .github/workflows/release-5.x.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index 99405dc4..89fcb35e 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -72,7 +72,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/tree/main/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 20e9797f..e26268df 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,7 +71,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/tree/main/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson From ca15dfef74a1b93a6d2342802cdf160959b062b5 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Fri, 31 May 2024 08:35:10 -0600 Subject: [PATCH 13/15] fix path --- .github/workflows/release-5.x.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index 89fcb35e..a37ae62d 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -72,7 +72,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@v2 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e26268df..49df7b2c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,7 +71,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@v2 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson From 533f5c9a873efb0cf4fccac1baaf01e960d30665 Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Fri, 31 May 2024 08:41:36 -0600 Subject: [PATCH 14/15] don't specify version --- .github/workflows/release-5.x.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index a37ae62d..89fcb35e 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -72,7 +72,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@v2 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 49df7b2c..e26268df 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,7 +71,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@v2 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson From a9582c2e996abf537fc18a4dfb7422aed14acf7d Mon Sep 17 00:00:00 2001 From: Bailey Pearson Date: Fri, 31 May 2024 08:42:46 -0600 Subject: [PATCH 15/15] fix path --- .github/workflows/release-5.x.yml | 2 +- .github/workflows/release.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release-5.x.yml b/.github/workflows/release-5.x.yml index 89fcb35e..711b11ad 100644 --- a/.github/workflows/release-5.x.yml +++ b/.github/workflows/release-5.x.yml @@ -72,7 +72,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@main with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index e26268df..3929d783 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -71,7 +71,7 @@ jobs: echo "package_version=${package_version}" >> "$GITHUB_OUTPUT" - name: actions/publish_asset_to_s3 - uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3 + uses: mongodb-labs/drivers-github-tools/node/publish_asset_to_s3@main with: version: ${{ steps.get_version.outputs.package_version }} product_name: js-bson