From c26c3fa501b43b7e18e3f7e65a906abbe0537cf2 Mon Sep 17 00:00:00 2001 From: Divine <48183131+divine@users.noreply.github.com> Date: Sat, 19 Sep 2020 16:48:58 +0300 Subject: [PATCH 01/15] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e06bad963..cb9c88f2b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ All notable changes to this project will be documented in this file. ## [Unreleased] +## [v3.7.0] - 2020-09-18 + ### Added - Laravel 7 support by [@divine](https://github.com/divine). From ebd1d80256b2740133baa1875dc7f102f130772c Mon Sep 17 00:00:00 2001 From: Divine <48183131+divine@users.noreply.github.com> Date: Sat, 19 Sep 2020 16:51:46 +0300 Subject: [PATCH 02/15] Remove v from version --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cb9c88f2b..432ed3a3c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ All notable changes to this project will be documented in this file. ## [Unreleased] -## [v3.7.0] - 2020-09-18 +## [3.7.0] - 2020-09-18 ### Added - Laravel 7 support by [@divine](https://github.com/divine). From b8d421d16ce0cd60c38f9ccc4734b2e3f6844aef Mon Sep 17 00:00:00 2001 From: divine <48183131+divine@users.noreply.github.com> Date: Tue, 22 Sep 2020 00:55:06 +0300 Subject: [PATCH 03/15] Laravel 8 support - Bump dependencies - Update test - Remove PHP 7.2 from github ci --- .github/workflows/build-ci.yml | 2 +- CHANGELOG.md | 6 ++++++ composer.json | 10 +++++----- tests/QueueTest.php | 2 +- 4 files changed, 13 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index d978a8536..593f72b0a 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -11,7 +11,7 @@ jobs: runs-on: ${{matrix.os}} strategy: matrix: - php: ['7.2', '7.3', '7.4'] + php: ['7.3', '7.4'] os: ['ubuntu-latest'] mongodb: ['3.6', '4.0', '4.2', '4.4'] services: diff --git a/CHANGELOG.md b/CHANGELOG.md index 432ed3a3c..614d35fa6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file. ## [Unreleased] +### Added +- Laravel 8 support by [@divine](https://github.com/divine). + +### Changed +- Updated versions of all dependencies by [@divine](https://github.com/divine). + ## [3.7.0] - 2020-09-18 ### Added diff --git a/composer.json b/composer.json index 872a48cd3..9a80bc1be 100644 --- a/composer.json +++ b/composer.json @@ -19,15 +19,15 @@ ], "license": "MIT", "require": { - "illuminate/support": "^7.0", - "illuminate/container": "^7.0", - "illuminate/database": "^7.0", - "illuminate/events": "^7.0", + "illuminate/support": "^8.0", + "illuminate/container": "^8.0", + "illuminate/database": "^8.0", + "illuminate/events": "^8.0", "mongodb/mongodb": "^1.6" }, "require-dev": { "phpunit/phpunit": "^8.4|^9.0", - "orchestra/testbench": "^5.0", + "orchestra/testbench": "^6.0", "mockery/mockery": "^1.3.1", "doctrine/dbal": "^2.6" }, diff --git a/tests/QueueTest.php b/tests/QueueTest.php index ce32c0979..5b07c9492 100644 --- a/tests/QueueTest.php +++ b/tests/QueueTest.php @@ -37,7 +37,7 @@ public function testQueueJobLifeCycle(): void 'job' => 'test', 'maxTries' => null, 'maxExceptions' => null, - 'delay' => null, + 'backoff' => null, 'timeout' => null, 'data' => ['action' => 'QueueJobLifeCycle'], ]), $job->getRawBody()); From 436cae8406e2fd80404f844108b99c0e517a50e9 Mon Sep 17 00:00:00 2001 From: divine <48183131+divine@users.noreply.github.com> Date: Tue, 22 Sep 2020 01:01:07 +0300 Subject: [PATCH 04/15] Require phpunit only ^9.0 - Remove phpunit ^8.4 - Migrate phpunit configuration "Your XML configuration validates against a deprecated schema." --- composer.json | 2 +- phpunit.xml.dist | 20 ++++++-------------- 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/composer.json b/composer.json index 9a80bc1be..35f7d26d8 100644 --- a/composer.json +++ b/composer.json @@ -26,7 +26,7 @@ "mongodb/mongodb": "^1.6" }, "require-dev": { - "phpunit/phpunit": "^8.4|^9.0", + "phpunit/phpunit": "^9.0", "orchestra/testbench": "^6.0", "mockery/mockery": "^1.3.1", "doctrine/dbal": "^2.6" diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 38d2b79c9..4dc18cb41 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -1,13 +1,10 @@ - + + + + ./src + + tests/ @@ -37,11 +34,6 @@ tests/ValidationTest.php - - - ./src - - From 942f9365d02770a937f8479ebb8a9966a00b4f88 Mon Sep 17 00:00:00 2001 From: divine <48183131+divine@users.noreply.github.com> Date: Tue, 22 Sep 2020 01:03:43 +0300 Subject: [PATCH 05/15] Update readme Add 3.8.x release for Laravel 8. --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index e801fd51b..c30100908 100644 --- a/README.md +++ b/README.md @@ -68,6 +68,7 @@ Make sure you have the MongoDB PHP driver installed. You can find installation i 5.8.x | 3.5.x 6.x | 3.6.x 7.x | 3.7.x + 8.x | 3.8.x Install the package via Composer: From 23437623fb026ee7f31bc24a36faaab5098b42ee Mon Sep 17 00:00:00 2001 From: Smolevich Date: Wed, 30 Sep 2020 00:15:37 +0300 Subject: [PATCH 06/15] Change matrix --- .github/workflows/build-ci.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index d978a8536..48513685b 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -9,11 +9,23 @@ on: jobs: build: runs-on: ${{matrix.os}} + name: PHP v${{ matrix.php }}, Mongo v${{ matrix.mongodb}} + continue-on-error: ${{ matrix.experimental }} strategy: matrix: - php: ['7.2', '7.3', '7.4'] - os: ['ubuntu-latest'] - mongodb: ['3.6', '4.0', '4.2', '4.4'] + include: + - { os: ubuntu-latest, php: 7.2, mongodb: 3.6, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.0, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.2, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.4, experimental: true} + - { os: ubuntu-latest, php: 7.3, mongodb: 3.6, experimental: false} + - { os: ubuntu-latest, php: 7.3, mongodb: 4.0, experimental: false} + - { os: ubuntu-latest, php: 7.3, mongodb: 4.2, experimental: false} + - { os: ubuntu-latest, php: 7.3, mongodb: 4.4, experimental: false} + - { os: ubuntu-latest, php: 7.4, mongodb: 3.6, experimental: false} + - { os: ubuntu-latest, php: 7.4, mongodb: 4.0, experimental: false} + - { os: ubuntu-latest, php: 7.4, mongodb: 4.2, experimental: false} + - { os: ubuntu-latest, php: 7.4, mongodb: 4.4, experimental: false} services: mongo: image: mongo:${{ matrix.mongodb }} From cf51510dc0d3b5374c7a01e671de94d436496095 Mon Sep 17 00:00:00 2001 From: Smolevich Date: Wed, 30 Sep 2020 00:24:04 +0300 Subject: [PATCH 07/15] fix workflow file --- .github/workflows/build-ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index 48513685b..84573f850 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -8,8 +8,8 @@ on: jobs: build: - runs-on: ${{matrix.os}} - name: PHP v${{ matrix.php }}, Mongo v${{ matrix.mongodb}} + runs-on: ${{ matrix.os }} + name: PHP v${{ matrix.php }} with Mongo v${{ matrix.mongodb }} continue-on-error: ${{ matrix.experimental }} strategy: matrix: @@ -39,7 +39,6 @@ jobs: MYSQL_ALLOW_EMPTY_PASSWORD: 'yes' MYSQL_DATABASE: 'unittest' MYSQL_ROOT_PASSWORD: - name: PHP v${{ matrix.php }} with Mongo v${{ matrix.mongodb }} steps: - uses: actions/checkout@v2 From 311c96d265aa4e40b07239d8a64a2a299f95b3d4 Mon Sep 17 00:00:00 2001 From: Smolevich Date: Wed, 30 Sep 2020 01:00:54 +0300 Subject: [PATCH 08/15] Add string fo 4.0 --- .github/workflows/build-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index 84573f850..363afd99f 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -15,15 +15,15 @@ jobs: matrix: include: - { os: ubuntu-latest, php: 7.2, mongodb: 3.6, experimental: true} - - { os: ubuntu-latest, php: 7.2, mongodb: 4.0, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: '4.0', experimental: true} - { os: ubuntu-latest, php: 7.2, mongodb: 4.2, experimental: true} - { os: ubuntu-latest, php: 7.2, mongodb: 4.4, experimental: true} - { os: ubuntu-latest, php: 7.3, mongodb: 3.6, experimental: false} - - { os: ubuntu-latest, php: 7.3, mongodb: 4.0, experimental: false} + - { os: ubuntu-latest, php: 7.3, mongodb: '4.0', experimental: false} - { os: ubuntu-latest, php: 7.3, mongodb: 4.2, experimental: false} - { os: ubuntu-latest, php: 7.3, mongodb: 4.4, experimental: false} - { os: ubuntu-latest, php: 7.4, mongodb: 3.6, experimental: false} - - { os: ubuntu-latest, php: 7.4, mongodb: 4.0, experimental: false} + - { os: ubuntu-latest, php: 7.4, mongodb: '4.0', experimental: false} - { os: ubuntu-latest, php: 7.4, mongodb: 4.2, experimental: false} - { os: ubuntu-latest, php: 7.4, mongodb: 4.4, experimental: false} services: From 5a43ecbfcbfd0d2c9cdcc4b090ac4203add85f27 Mon Sep 17 00:00:00 2001 From: Divine <48183131+divine@users.noreply.github.com> Date: Wed, 30 Sep 2020 10:03:32 +0300 Subject: [PATCH 09/15] Fix breaking change for morphto Breaking change in minor release https://github.com/laravel/framework/pull/34531 --- src/Jenssegers/Mongodb/Relations/MorphTo.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Jenssegers/Mongodb/Relations/MorphTo.php b/src/Jenssegers/Mongodb/Relations/MorphTo.php index 704c4722c..5938f9eeb 100644 --- a/src/Jenssegers/Mongodb/Relations/MorphTo.php +++ b/src/Jenssegers/Mongodb/Relations/MorphTo.php @@ -31,7 +31,7 @@ protected function getResultsByType($type) $query = $instance->newQuery(); - return $query->whereIn($key, $this->gatherKeysByType($type))->get(); + return $query->whereIn($key, $this->gatherKeysByType($type, $instance->getKeyType()))->get(); } /** From 21f4d7ad7b4615466bb487e8f56f673dcba7cfe1 Mon Sep 17 00:00:00 2001 From: Divine <48183131+divine@users.noreply.github.com> Date: Wed, 30 Sep 2020 10:09:48 +0300 Subject: [PATCH 10/15] Revert github workflow --- .github/workflows/build-ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index 7cd78ca0b..289d2de51 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -14,6 +14,10 @@ jobs: strategy: matrix: include: + - { os: ubuntu-latest, php: 7.2, mongodb: 3.6, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: '4.0', experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.2, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.4, experimental: true} - { os: ubuntu-latest, php: 7.3, mongodb: 3.6, experimental: false} - { os: ubuntu-latest, php: 7.3, mongodb: '4.0', experimental: false} - { os: ubuntu-latest, php: 7.3, mongodb: 4.2, experimental: false} @@ -73,4 +77,4 @@ jobs: - uses: codecov/codecov-action@v1 with: token: ${{ secrets.CODECOV_TOKEN }} - fail_ci_if_error: false \ No newline at end of file + fail_ci_if_error: false From f1cce13eaff317f8fcb3eb569e9727c3cebb798c Mon Sep 17 00:00:00 2001 From: divine <48183131+divine@users.noreply.github.com> Date: Wed, 30 Sep 2020 11:54:34 +0300 Subject: [PATCH 11/15] Fix php 7.2 matrix --- .github/workflows/build-ci.yml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml index 289d2de51..51a117fa9 100644 --- a/.github/workflows/build-ci.yml +++ b/.github/workflows/build-ci.yml @@ -14,9 +14,9 @@ jobs: strategy: matrix: include: - - { os: ubuntu-latest, php: 7.2, mongodb: 3.6, experimental: true} - - { os: ubuntu-latest, php: 7.2, mongodb: '4.0', experimental: true} - - { os: ubuntu-latest, php: 7.2, mongodb: 4.2, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 3.6, experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: '4.0', experimental: true} + - { os: ubuntu-latest, php: 7.2, mongodb: 4.2, experimental: true} - { os: ubuntu-latest, php: 7.2, mongodb: 4.4, experimental: true} - { os: ubuntu-latest, php: 7.3, mongodb: 3.6, experimental: false} - { os: ubuntu-latest, php: 7.3, mongodb: '4.0', experimental: false} @@ -56,18 +56,22 @@ jobs: env: DEBUG: ${{secrets.DEBUG}} - name: Download Composer cache dependencies from cache + if: (!startsWith(matrix.php, '7.2')) id: composer-cache run: echo "::set-output name=dir::$(composer config cache-files-dir)" - name: Cache Composer dependencies + if: (!startsWith(matrix.php, '7.2')) uses: actions/cache@v1 with: path: ${{ steps.composer-cache.outputs.dir }} key: ${{ matrix.os }}-composer-${{ hashFiles('**/composer.json') }} restore-keys: ${{ matrix.os }}-composer- - name: Install dependencies + if: (!startsWith(matrix.php, '7.2')) run: | composer install --no-interaction - name: Run tests + if: (!startsWith(matrix.php, '7.2')) run: | ./vendor/bin/phpunit --coverage-clover coverage.xml env: From e7a385acd33f0c4025d4133bd6a40ba13b0ea762 Mon Sep 17 00:00:00 2001 From: Hazem Nassr Date: Mon, 19 Oct 2020 16:28:12 +0300 Subject: [PATCH 12/15] Fix when the value is numeric in where like --- src/Jenssegers/Mongodb/Query/Builder.php | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/Jenssegers/Mongodb/Query/Builder.php b/src/Jenssegers/Mongodb/Query/Builder.php index 86526ed53..9642b9cbc 100644 --- a/src/Jenssegers/Mongodb/Query/Builder.php +++ b/src/Jenssegers/Mongodb/Query/Builder.php @@ -993,7 +993,6 @@ protected function compileWhereAll(array $where) protected function compileWhereBasic(array $where) { extract($where); - $is_numeric = false; // Replace like or not like with a Regex instance. if (in_array($operator, ['like', 'not like'])) { @@ -1019,7 +1018,6 @@ protected function compileWhereBasic(array $where) $plain_value = Str::replaceLast('%', null, $plain_value); } - $is_numeric = is_numeric($plain_value); $value = new Regex($regex, 'i'); } // Manipulate regexp operations. elseif (in_array($operator, ['regexp', 'not regexp', 'regex', 'not regex'])) { @@ -1039,11 +1037,7 @@ protected function compileWhereBasic(array $where) } if (!isset($operator) || $operator == '=') { - if ($is_numeric) { - $query = ['$where' => '/^'.$value->getPattern().'/.test(this.'.$column.')']; - } else { - $query = [$column => $value]; - } + $query = [$column => $value]; } elseif (array_key_exists($operator, $this->conversion)) { $query = [$column => [$this->conversion[$operator] => $value]]; } else { From a3bcbe9af60921543d0cd5fa8a45e2372d1c26cc Mon Sep 17 00:00:00 2001 From: Hazem Nassr Date: Wed, 21 Oct 2020 21:16:14 +0300 Subject: [PATCH 13/15] Fix when column have hyphen (-) --- src/Jenssegers/Mongodb/Query/Builder.php | 8 +++++++- tests/QueryTest.php | 4 ++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/Jenssegers/Mongodb/Query/Builder.php b/src/Jenssegers/Mongodb/Query/Builder.php index 9642b9cbc..e466ea411 100644 --- a/src/Jenssegers/Mongodb/Query/Builder.php +++ b/src/Jenssegers/Mongodb/Query/Builder.php @@ -993,6 +993,7 @@ protected function compileWhereAll(array $where) protected function compileWhereBasic(array $where) { extract($where); + $is_numeric = false; // Replace like or not like with a Regex instance. if (in_array($operator, ['like', 'not like'])) { @@ -1018,6 +1019,7 @@ protected function compileWhereBasic(array $where) $plain_value = Str::replaceLast('%', null, $plain_value); } + $is_numeric = is_numeric($plain_value); $value = new Regex($regex, 'i'); } // Manipulate regexp operations. elseif (in_array($operator, ['regexp', 'not regexp', 'regex', 'not regex'])) { @@ -1037,7 +1039,11 @@ protected function compileWhereBasic(array $where) } if (!isset($operator) || $operator == '=') { - $query = [$column => $value]; + if ($is_numeric) { + $query = ['$where' => '/^'.$value->getPattern().'/.test(this["'.$column.'"])']; + } else { + $query = [$column => $value]; + } } elseif (array_key_exists($operator, $this->conversion)) { $query = [$column => [$this->conversion[$operator] => $value]]; } else { diff --git a/tests/QueryTest.php b/tests/QueryTest.php index 5e6261b52..fdf6f7c04 100644 --- a/tests/QueryTest.php +++ b/tests/QueryTest.php @@ -16,6 +16,7 @@ public function setUp(): void User::create(['name' => 'Brett Boe', 'age' => 35, 'title' => 'user']); User::create(['name' => 'Tommy Toe', 'age' => 33, 'title' => 'user']); User::create(['name' => 'Yvonne Yoe', 'age' => 35, 'title' => 'admin']); + User::create(['name' => 'Hazem Nassr', 'user-age' => 28, 'title' => 'member']); User::create(['name' => 'Error', 'age' => null, 'title' => null]); } @@ -78,6 +79,9 @@ public function testLike(): void $users = User::where('age', 'like', '%3')->get(); $this->assertCount(4, $users); + + $users = User::where('user-age', 'like', '%28')->get(); + $this->assertCount(1, $users); } public function testNotLike(): void From dd413de03ef8b456039077cf5e48673eabf64417 Mon Sep 17 00:00:00 2001 From: Hazem Nassr Date: Wed, 21 Oct 2020 21:26:22 +0300 Subject: [PATCH 14/15] Fix test --- tests/QueryTest.php | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tests/QueryTest.php b/tests/QueryTest.php index fdf6f7c04..a6e86e6e6 100644 --- a/tests/QueryTest.php +++ b/tests/QueryTest.php @@ -42,10 +42,10 @@ public function testWhere(): void $this->assertCount(1, $users); $users = User::where('age', '!=', 35)->get(); - $this->assertCount(6, $users); + $this->assertCount(7, $users); $users = User::where('age', '<>', 35)->get(); - $this->assertCount(6, $users); + $this->assertCount(7, $users); } public function testAndWhere(): void @@ -87,16 +87,16 @@ public function testLike(): void public function testNotLike(): void { $users = User::where('name', 'not like', '%doe')->get(); - $this->assertCount(7, $users); + $this->assertCount(8, $users); $users = User::where('name', 'not like', '%y%')->get(); - $this->assertCount(6, $users); + $this->assertCount(7, $users); $users = User::where('name', 'not LIKE', '%y%')->get(); - $this->assertCount(6, $users); + $this->assertCount(7, $users); $users = User::where('name', 'not like', 't%')->get(); - $this->assertCount(8, $users); + $this->assertCount(9, $users); } public function testSelect(): void @@ -156,7 +156,7 @@ public function testIn(): void $this->assertCount(6, $users); $users = User::whereNotIn('age', [33, 35])->get(); - $this->assertCount(4, $users); + $this->assertCount(5, $users); $users = User::whereNotNull('age') ->whereNotIn('age', [33, 35])->get(); @@ -166,7 +166,7 @@ public function testIn(): void public function testWhereNull(): void { $users = User::whereNull('age')->get(); - $this->assertCount(1, $users); + $this->assertCount(2, $users); } public function testWhereNotNull(): void @@ -199,7 +199,7 @@ public function testOrder(): void public function testGroupBy(): void { $users = User::groupBy('title')->get(); - $this->assertCount(3, $users); + $this->assertCount(4, $users); $users = User::groupBy('age')->get(); $this->assertCount(6, $users); @@ -229,11 +229,11 @@ public function testGroupBy(): void public function testCount(): void { $count = User::where('age', '<>', 35)->count(); - $this->assertEquals(6, $count); + $this->assertEquals(7, $count); // Test for issue #165 $count = User::select('_id', 'age', 'title')->where('age', '<>', 35)->count(); - $this->assertEquals(6, $count); + $this->assertEquals(7, $count); } public function testExists(): void @@ -331,12 +331,12 @@ public function testPaginate(): void $results = User::paginate(2); $this->assertEquals(2, $results->count()); $this->assertNotNull($results->first()->title); - $this->assertEquals(9, $results->total()); + $this->assertEquals(10, $results->total()); $results = User::paginate(2, ['name', 'age']); $this->assertEquals(2, $results->count()); $this->assertNull($results->first()->title); - $this->assertEquals(9, $results->total()); + $this->assertEquals(10, $results->total()); $this->assertEquals(1, $results->currentPage()); } From 864c0a75958ca46cf59edf103e30a8645b67f699 Mon Sep 17 00:00:00 2001 From: Divine <48183131+divine@users.noreply.github.com> Date: Thu, 22 Oct 2020 05:45:28 +0300 Subject: [PATCH 15/15] Change name to neutral --- tests/QueryTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/QueryTest.php b/tests/QueryTest.php index a6e86e6e6..d7c170495 100644 --- a/tests/QueryTest.php +++ b/tests/QueryTest.php @@ -16,7 +16,7 @@ public function setUp(): void User::create(['name' => 'Brett Boe', 'age' => 35, 'title' => 'user']); User::create(['name' => 'Tommy Toe', 'age' => 33, 'title' => 'user']); User::create(['name' => 'Yvonne Yoe', 'age' => 35, 'title' => 'admin']); - User::create(['name' => 'Hazem Nassr', 'user-age' => 28, 'title' => 'member']); + User::create(['name' => 'John Smith', 'user-age' => 28, 'title' => 'member']); User::create(['name' => 'Error', 'age' => null, 'title' => null]); }