Table column vertical alignment
#2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fygreen-ui into shaneeza/table-column-vertical-alignment
|
|
Size Change: +98 B (+0.01%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
Base automatically changed from
shaneeza/table-sticky-shadow
to
table-refactor-integration
November 20, 2024 15:11
…green-ui into shaneeza/table-column-vertical-alignment
stephl3
reviewed
Nov 21, 2024
Comment on lines
-31
to
+33
| className={cx(baseCellStyles, className)} | ||
| className={cx(getBaseCellStyles(verticalAlignment), className)} |
There was a problem hiding this comment.
nit: lately, I've been consuming @leafygreen-ui/emotion only in the *.styles.ts file and passing all variables including className into the style function. In this case, you end up with something like getCellStyles(className, verticalAlignment)
There was a problem hiding this comment.
I like this pattern. However, I'm going to keep it as is. If I have extra time, I'll go back and update all table styles to match this pattern.
| @@ -242,7 +271,6 @@ DisabledClickableRows.args = { | |||
| export const DisabledSelectableRows: StoryFn< | |||
| RowProps<Person> & DarkModeProps | |||
| > = ({ darkMode, ...args }: DarkModeProps & RowProps<Person>) => { | |||
| const tableContainerRef = React.useRef<HTMLDivElement>(null); | |||
There was a problem hiding this comment.
It's not necessary for a regular table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
In this PR, I added a new prop to
TablecalledverticalAlignment. This prop controls the vertical alignment of rows that span multiple lines. The available options areTop(default) andMiddle.✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes in Storybook
Table>No Truncation: toggleverticalAlignmentTable>With Virtualized Scrolling>No Truncation: toggleverticalAlignment