CSHARP-5717: Typed builders for vector indexes #1795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements typed builders for creating vector indexes in MongoDB Atlas, providing a strongly-typed C# API as an alternative to manually constructing BsonDocument definitions. The changes introduce new enums for vector similarity and quantization, a base class for index models, and a generic CreateVectorIndexModel<TDocument> class that leverages C# expressions for field selection.
Key changes:
- Adds
VectorSimilarityandVectorQuantizationenums to represent vector search configuration options - Introduces
CreateSearchIndexModelBaseabstract class and refactorsCreateSearchIndexModelto inherit from it - Implements
CreateVectorIndexModel<TDocument>for type-safe vector index creation with support for filter fields and HNSW options
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/MongoDB.Driver/VectorSimilarity.cs | Defines enum for vector similarity functions (Euclidean, Cosine, DotProduct) |
| src/MongoDB.Driver/VectorQuantization.cs | Defines enum for vector quantization types (None, Scalar, Binary) |
| src/MongoDB.Driver/CreateSearchIndexModelBase.cs | Introduces abstract base class for search index models |
| src/MongoDB.Driver/CreateSearchIndexModel.cs | Refactors to inherit from base class and updates documentation |
| src/MongoDB.Driver/CreateVectorIndexModel.cs | Implements typed vector index model with field expressions and rendering logic |
| src/MongoDB.Driver/Search/IMongoSearchIndexManager.cs | Updates interface to accept base class type |
| src/MongoDB.Driver/MongoCollectionImpl.cs | Updates implementation to handle both search and vector index models |
| tests/MongoDB.Driver.Tests/Search/AtlasSearchIndexManagmentTests.cs | Adds comprehensive tests for typed vector index API and updates existing tests |
| evergreen/evergreen.yml | Updates MongoDB version from 7.0 to 8.0 for search index tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@rstam This is a new implementation which, I think, does the rendering properly. |
rstam
reviewed
Oct 17, 2025
rstam
requested changes
Oct 20, 2025
ajcvickers
added
the
improvement
ajcvickers
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1769