GODRIVER-2962 Remove setters from Aggregate.

[matthewdale]

GODRIVER-2962

Summary

Remove setters from Aggregate.

Background & Motivation

The field setters on the operation types in the x/mongo/driver/operation package provide no usability improvement but create a maintenance burden whenever we have to update the operations. Remove the field setters and use struct literals instead.

Split the change into multiple PRs to make reviewing them easier.

[github-actions]

API Change Report

./x/mongo/driver/operation

incompatible changes

(*Aggregate).AllowDiskUse: removed
(*Aggregate).BatchSize: removed
(*Aggregate).BypassDocumentValidation: removed
(*Aggregate).ClusterClock: removed
(*Aggregate).Collation: removed
(*Aggregate).Collection: removed
(*Aggregate).CommandMonitor: removed
(*Aggregate).Comment: removed
(*Aggregate).Crypt: removed
(*Aggregate).CustomOptions: removed
(*Aggregate).Database: removed
(*Aggregate).Deployment: removed
(*Aggregate).HasOutputStage: removed
(*Aggregate).Hint: removed
(*Aggregate).Let: removed
(*Aggregate).MaxTime: removed
(*Aggregate).Pipeline: removed
(*Aggregate).ReadConcern: removed
(*Aggregate).ReadPreference: removed
(*Aggregate).Retry: removed
(*Aggregate).ServerAPI: removed
(*Aggregate).ServerSelector: removed
(*Aggregate).Session: removed
(*Aggregate).Timeout: removed
(*Aggregate).WriteConcern: removed
NewAggregate: removed

compatible changes

Aggregate.AllowDiskUse: added
Aggregate.BatchSize: added
Aggregate.BypassDocumentValidation: added
Aggregate.Clock: added
Aggregate.Collation: added
Aggregate.Collection: added
Aggregate.Comment: added
Aggregate.Crypt: added
Aggregate.CustomOptions: added
Aggregate.Database: added
Aggregate.Deployment: added
Aggregate.HasOutputStage: added
Aggregate.Hint: added
Aggregate.Let: added
Aggregate.MaxTime: added
Aggregate.Monitor: added
Aggregate.Pipeline: added
Aggregate.ReadConcern: added
Aggregate.ReadPreference: added
Aggregate.Retry: added
Aggregate.Selector: added
Aggregate.ServerAPI: added
Aggregate.Session: added
Aggregate.Timeout: added
Aggregate.WriteConcern: added

[blink1073]

LGTM!

The base branch was changed.

[blink1073]

Is this meant to be part of the 2.0 epic then?

[matthewdale]

@blink1073 no, this is not a strictly v2 change. I switched the branch to minimize the additional work required to sync changes from v1 to master because it isn't required in v1.

[blink1073]

Should we mark the setters as deprecated in v1?

[matthewdale]

@blink1073 Yes. Considering the feedback we've received about the unannounced removal of some other experimental APIs, I think marking those as deprecated in v1.x would be useful messaging.

[matthewdale]

Closing this for now, will follow up later when GODRIVER-2962 is scheduled.