GODRIVER-3248 Update windows CI build #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
blink1073
reviewed
Jun 14, 2024
| @@ -2393,21 +2393,28 @@ buildvariants: | |||
|
|
|||
| - matrix_name: "tests-36-with-zlib-support" | |||
| tags: ["pullrequest"] | |||
| matrix_spec: { version: ["3.6"], os-ssl-32: ["windows-64-go-1-20", "rhel87-64-go-1-20"] } | |||
| matrix_spec: { version: ["3.6"], os-ssl-32: ["rhel87-64-go-1-20"] } | |||
There was a problem hiding this comment.
I think we should create windows versions without the pullrequest tag instead of removing windows altogether.
There was a problem hiding this comment.
This PR still proposes testing for windows on 8.0 on pullrequest. @blink1073 Are you suggesting we also account for the waterfall case:
- matrix_name: "tests-80-plus-windows-zlib-zstd-support"
matrix_spec: { version: ["4.2", "4.4", "5.0", "6.0", "7.0", "8.0"], os-ssl-40: ["windows-64-go-1-20"] }
display_name: "${version} ${os-ssl-40}"
tasks:
- name: ".test !.enterprise-auth !.snappy"There was a problem hiding this comment.
I want to ensure that we're testing 3.6-7.0 with Windows on git push.
There was a problem hiding this comment.
I've updated the PR to only run Windows builds for server version 8.0 on PRs. However, still run 3.6-7.0 when merging a PR.
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Jun 27, 2024
(cherry picked from commit ba4f865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3248
Summary
windows-vsCurrent-smallBackground & Motivation